Re: [PATCH] block: pmem: Add dependency on HAS_IOMEM

[Richard Weinberger <richard@nod.at>]

Am 04.05.2015 um 22:00 schrieb Ross Zwisler:
> On Mon, 2015-05-04 at 20:58 +0200, Richard Weinberger wrote:
>> Not all architectures have io memory.
>>
>> Fixes:
>> drivers/block/pmem.c: In function ‘pmem_alloc’:
>> drivers/block/pmem.c:146:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]
>>   pmem->virt_addr = ioremap_nocache(pmem->phys_addr, pmem->size);
>>   ^
>> drivers/block/pmem.c:146:18: warning: assignment makes pointer from integer without a cast [enabled by default]
>>   pmem->virt_addr = ioremap_nocache(pmem->phys_addr, pmem->size);
>>                   ^
>> drivers/block/pmem.c:182:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>>   iounmap(pmem->virt_addr);
>>   ^
>>
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>> ---
>>  drivers/block/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
>> index eb1fed5..3ccef9e 100644
>> --- a/drivers/block/Kconfig
>> +++ b/drivers/block/Kconfig
>> @@ -406,6 +406,7 @@ config BLK_DEV_RAM_DAX
>>  
>>  config BLK_DEV_PMEM
>>  	tristate "Persistent memory block device support"
>> +	depends on HAS_IOMEM
>>  	help
>>  	  Saying Y here will allow you to use a contiguous range of reserved
>>  	  memory as one or more persistent block devices.
> 
> Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>

Ping?

Thanks,
//richard