From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Colin King <colin.king@canonical.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Felipe Balbi <balbi@ti.com>, Sudeep Holla <sudeep.holla@arm.com>,
linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: isp1760: fix null dereference if kzalloc returns null
Date: Mon, 01 Jun 2015 01:15:24 +0300 [thread overview]
Message-ID: <556B87FC.5080908@cogentembedded.com> (raw)
In-Reply-To: <1433109649-4086-1-git-send-email-colin.king@canonical.com>
Hello.
On 06/01/2015 01:00 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> If kzalloc returns null then isp1760_ep_alloc_request performs
> a null pointer deference on req.
Dereference, not "deference".
No, it doesn't. It calculates the address of the 'isp1760_request::req'
instead, there's no dereference per se. I suppose this is a first member of
the structure, so this function should work correctly in any case.
> Check for null to avoid this.
> Detected with smatch static analysis:
>
> drivers/usb/isp1760/isp1760-udc.c:816 isp1760_ep_alloc_request()
> error: potential null dereference 'req'. (kzalloc returns null)
Well, the change won't hurt anyway, makes things clearer.
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
WBR, Sergei
next prev parent reply other threads:[~2015-05-31 22:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-31 22:00 [PATCH] usb: isp1760: fix null dereference if kzalloc returns null Colin King
2015-05-31 22:15 ` Sergei Shtylyov [this message]
2015-05-31 22:41 ` Colin Ian King
2015-06-01 11:09 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556B87FC.5080908@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=balbi@ti.com \
--cc=colin.king@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.