From: Jonathan Cameron <jic23@kernel.org>
To: Laurent Navet <laurent.navet@gmail.com>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: buffer: remove unneeded test
Date: Mon, 01 Jun 2015 08:48:03 +0100 [thread overview]
Message-ID: <556C0E33.9050206@kernel.org> (raw)
In-Reply-To: <1433018136-7108-1-git-send-email-laurent.navet@gmail.com>
On 30/05/15 21:35, Laurent Navet wrote:
> The same code is executed regardless ret value, so this test
> can be removed.
> Also fix coverity scan CID 1268786.
>
> Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
Applied to the togreg branch of iio.git. Will push out
as testing when not stuck in a cleanroom with no net access
(but curiously with my less than entirely clean laptop ;)
Jonathan
> ---
> drivers/iio/industrialio-buffer.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
> index df919f4..e7fbcce 100644
> --- a/drivers/iio/industrialio-buffer.c
> +++ b/drivers/iio/industrialio-buffer.c
> @@ -806,8 +806,6 @@ static ssize_t iio_buffer_store_enable(struct device *dev,
> ret = __iio_update_buffers(indio_dev,
> NULL, indio_dev->buffer);
>
> - if (ret < 0)
> - goto done;
> done:
> mutex_unlock(&indio_dev->mlock);
> return (ret < 0) ? ret : len;
>
prev parent reply other threads:[~2015-06-01 21:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-30 20:35 [PATCH] iio: buffer: remove unneeded test Laurent Navet
2015-06-01 7:48 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556C0E33.9050206@kernel.org \
--to=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=laurent.navet@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.