From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Bob Liu <bob.liu@oracle.com>, <xen-devel@lists.xen.org>
Cc: <david.vrabel@citrix.com>, <justing@spectralogic.com>,
<konrad.wilk@oracle.com>, <paul.durrant@citrix.com>,
<julien.grall@citrix.com>, <boris.ostrovsky@oracle.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: xen-blkfront: blkif_recover: recheck feature-persistent
Date: Mon, 1 Jun 2015 09:50:28 +0200 [thread overview]
Message-ID: <556C0EC4.5050206@citrix.com> (raw)
In-Reply-To: <1432599094-22245-1-git-send-email-bob.liu@oracle.com>
El 26/05/15 a les 2.11, Bob Liu ha escrit:
> When migrate from !feature-persistent host to feature-persistent host, domU
> still think new host/backend don't support persistent.
> Dmesg like:
> backed has not unmapped grant: 839
> backed has not unmapped grant: 773
> backed has not unmapped grant: 773
> backed has not unmapped grant: 773
> backed has not unmapped grant: 839
>
> We should recheck whether the new backend support feature-persistent during
> blkif_recover().
Right, we recheck for indirect-descriptors but not persistent grants.
Do you think it makes sense to split the part of blkfront_connect that
checks for optional features, like persistent grants, indirect
descriptors and flush/barrier features to a separate function and call
it from both blkfront_connect and blkif_recover?
Roger.
next prev parent reply other threads:[~2015-06-01 7:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 0:11 [PATCH] drivers: xen-blkfront: blkif_recover: recheck feature-persistent Bob Liu
2015-06-01 7:50 ` Roger Pau Monné [this message]
2015-06-01 8:30 ` Bob Liu
2015-06-01 8:30 ` Bob Liu
2015-06-01 7:50 ` Roger Pau Monné
-- strict thread matches above, loose matches on Subject: below --
2015-05-26 0:11 Bob Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556C0EC4.5050206@citrix.com \
--to=roger.pau@citrix.com \
--cc=bob.liu@oracle.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=julien.grall@citrix.com \
--cc=justing@spectralogic.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.durrant@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.