* [PATCH bluetooth-next 0/3] rdev-ops trace fixes
@ 2015-06-01 4:33 Varka Bhadram
2015-06-01 4:33 ` [PATCH bluetooth-next 1/3] ieee802154: trace: fix name for tx power value Varka Bhadram
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Varka Bhadram @ 2015-06-01 4:33 UTC (permalink / raw)
To: linux-wpan; +Cc: alex.aring, Varka Bhadram
Varka Bhadram (3):
ieee802154: trace: fix name for tx power value
ieee802154: trace: fix name for extended address
ieee802154: trace: fix extended addr format specifier
net/ieee802154/trace.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
1.7.9.5
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH bluetooth-next 1/3] ieee802154: trace: fix name for tx power value 2015-06-01 4:33 [PATCH bluetooth-next 0/3] rdev-ops trace fixes Varka Bhadram @ 2015-06-01 4:33 ` Varka Bhadram 2015-06-01 4:33 ` [PATCH bluetooth-next 2/3] ieee802154: trace: fix name for extended address Varka Bhadram 2015-06-01 4:33 ` [PATCH bluetooth-next 3/3] ieee802154: trace: fix extended addr format specifier Varka Bhadram 2 siblings, 0 replies; 7+ messages in thread From: Varka Bhadram @ 2015-06-01 4:33 UTC (permalink / raw) To: linux-wpan; +Cc: alex.aring, Varka Bhadram Signed-off-by: Varka Bhadram <varkab@cdac.in> --- net/ieee802154/trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ieee802154/trace.h b/net/ieee802154/trace.h index 73eb760..b4295fd 100644 --- a/net/ieee802154/trace.h +++ b/net/ieee802154/trace.h @@ -104,7 +104,7 @@ TRACE_EVENT(802154_rdev_set_tx_power, WPAN_PHY_ASSIGN; __entry->power = power; ), - TP_printk(WPAN_PHY_PR_FMT ", power: %d", WPAN_PHY_PR_ARG, + TP_printk(WPAN_PHY_PR_FMT ", mbm: %d", WPAN_PHY_PR_ARG, __entry->power) ); -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH bluetooth-next 2/3] ieee802154: trace: fix name for extended address 2015-06-01 4:33 [PATCH bluetooth-next 0/3] rdev-ops trace fixes Varka Bhadram 2015-06-01 4:33 ` [PATCH bluetooth-next 1/3] ieee802154: trace: fix name for tx power value Varka Bhadram @ 2015-06-01 4:33 ` Varka Bhadram 2015-06-01 7:37 ` Stefan Schmidt 2015-06-01 4:33 ` [PATCH bluetooth-next 3/3] ieee802154: trace: fix extended addr format specifier Varka Bhadram 2 siblings, 1 reply; 7+ messages in thread From: Varka Bhadram @ 2015-06-01 4:33 UTC (permalink / raw) To: linux-wpan; +Cc: alex.aring, Varka Bhadram Signed-off-by: Varka Bhadram <varkab@cdac.in> --- net/ieee802154/trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ieee802154/trace.h b/net/ieee802154/trace.h index b4295fd..9b5eefc 100644 --- a/net/ieee802154/trace.h +++ b/net/ieee802154/trace.h @@ -56,7 +56,7 @@ TRACE_EVENT(802154_rdev_add_virtual_intf, __entry->type = type; __entry->extended_addr = extended_addr; ), - TP_printk(WPAN_PHY_PR_FMT ", virtual intf name: %s, type: %d, ea %llx", + TP_printk(WPAN_PHY_PR_FMT ", virtual intf name: %s, type: %d, extended addr: %llx", WPAN_PHY_PR_ARG, __get_str(vir_intf_name), __entry->type, __le64_to_cpu(__entry->extended_addr)) ); -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH bluetooth-next 2/3] ieee802154: trace: fix name for extended address 2015-06-01 4:33 ` [PATCH bluetooth-next 2/3] ieee802154: trace: fix name for extended address Varka Bhadram @ 2015-06-01 7:37 ` Stefan Schmidt 2015-06-01 8:15 ` Alexander Aring 0 siblings, 1 reply; 7+ messages in thread From: Stefan Schmidt @ 2015-06-01 7:37 UTC (permalink / raw) To: Varka Bhadram, linux-wpan; +Cc: alex.aring, Varka Bhadram Hello. On 01/06/15 06:33, Varka Bhadram wrote: > Signed-off-by: Varka Bhadram <varkab@cdac.in> > --- > net/ieee802154/trace.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ieee802154/trace.h b/net/ieee802154/trace.h > index b4295fd..9b5eefc 100644 > --- a/net/ieee802154/trace.h > +++ b/net/ieee802154/trace.h > @@ -56,7 +56,7 @@ TRACE_EVENT(802154_rdev_add_virtual_intf, > __entry->type = type; > __entry->extended_addr = extended_addr; > ), > - TP_printk(WPAN_PHY_PR_FMT ", virtual intf name: %s, type: %d, ea %llx", > + TP_printk(WPAN_PHY_PR_FMT ", virtual intf name: %s, type: %d, extended addr: %llx", > WPAN_PHY_PR_ARG, __get_str(vir_intf_name), __entry->type, > __le64_to_cpu(__entry->extended_addr)) > ); Please merge this with the third patch. Its really the same line and fixes the output and format specifier. I don't see a need to have two patches for this. regards Stefan Schmidt ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH bluetooth-next 2/3] ieee802154: trace: fix name for extended address 2015-06-01 7:37 ` Stefan Schmidt @ 2015-06-01 8:15 ` Alexander Aring 2015-06-01 8:41 ` Varka Bhadram 0 siblings, 1 reply; 7+ messages in thread From: Alexander Aring @ 2015-06-01 8:15 UTC (permalink / raw) To: Stefan Schmidt; +Cc: Varka Bhadram, linux-wpan, Varka Bhadram On Mon, Jun 01, 2015 at 09:37:49AM +0200, Stefan Schmidt wrote: > Hello. > > On 01/06/15 06:33, Varka Bhadram wrote: > >Signed-off-by: Varka Bhadram <varkab@cdac.in> > >--- > > net/ieee802154/trace.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git a/net/ieee802154/trace.h b/net/ieee802154/trace.h > >index b4295fd..9b5eefc 100644 > >--- a/net/ieee802154/trace.h > >+++ b/net/ieee802154/trace.h > >@@ -56,7 +56,7 @@ TRACE_EVENT(802154_rdev_add_virtual_intf, > > __entry->type = type; > > __entry->extended_addr = extended_addr; > > ), > >- TP_printk(WPAN_PHY_PR_FMT ", virtual intf name: %s, type: %d, ea %llx", > >+ TP_printk(WPAN_PHY_PR_FMT ", virtual intf name: %s, type: %d, extended addr: %llx", > > WPAN_PHY_PR_ARG, __get_str(vir_intf_name), __entry->type, > > __le64_to_cpu(__entry->extended_addr)) > > ); > Please merge this with the third patch. Its really the same line and fixes > the output and format specifier. I don't see a need to have two patches for > this. > I would say fixup all patches into one and put it into the mac802154 trace functionality at first. What I told in my other mail was that we should use the same naming convention in cfg802154 and mac802154 trace for the same meaning of parameter. Varka fixed that for the attributes which I shown as _an_ _example_ only, that's fine. But when I look again into this stuff then I see for example "short address setting". The parameter in cfg802154 trace is named as "sa" and in mac802154 shown as "short addr", we should keep the same name for that (maybe ortiented by driver ops parameter naming). So far I know, "sa" is also used sometimes in the stack for "source address" [0]. Just keeping the same naming convention because there exists a relationship between mac802154 driver ops and cfg802154_ops which is called by rdev-ops. - Alex [0] http://lxr.free-electrons.com/source/net/ieee802154/6lowpan/tx.c#L209 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH bluetooth-next 2/3] ieee802154: trace: fix name for extended address 2015-06-01 8:15 ` Alexander Aring @ 2015-06-01 8:41 ` Varka Bhadram 0 siblings, 0 replies; 7+ messages in thread From: Varka Bhadram @ 2015-06-01 8:41 UTC (permalink / raw) To: Alexander Aring, Stefan Schmidt; +Cc: linux-wpan, Varka Bhadram Hi, On 06/01/2015 01:45 PM, Alexander Aring wrote: > On Mon, Jun 01, 2015 at 09:37:49AM +0200, Stefan Schmidt wrote: >> Hello. >> >> On 01/06/15 06:33, Varka Bhadram wrote: >>> Signed-off-by: Varka Bhadram <varkab@cdac.in> >>> --- >>> net/ieee802154/trace.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/net/ieee802154/trace.h b/net/ieee802154/trace.h >>> index b4295fd..9b5eefc 100644 >>> --- a/net/ieee802154/trace.h >>> +++ b/net/ieee802154/trace.h >>> @@ -56,7 +56,7 @@ TRACE_EVENT(802154_rdev_add_virtual_intf, >>> __entry->type = type; >>> __entry->extended_addr = extended_addr; >>> ), >>> - TP_printk(WPAN_PHY_PR_FMT ", virtual intf name: %s, type: %d, ea %llx", >>> + TP_printk(WPAN_PHY_PR_FMT ", virtual intf name: %s, type: %d, extended addr: %llx", >>> WPAN_PHY_PR_ARG, __get_str(vir_intf_name), __entry->type, >>> __le64_to_cpu(__entry->extended_addr)) >>> ); >> Please merge this with the third patch. Its really the same line and fixes >> the output and format specifier. I don't see a need to have two patches for >> this. >> > I would say fixup all patches into one and put it into the mac802154 > trace functionality at first. Do you mean that a single patch for all these fixes.? > What I told in my other mail was that we should use the same naming > convention in cfg802154 and mac802154 trace for the same meaning of > parameter. Varka fixed that for the attributes which I shown as _an_ > _example_ only, that's fine. > > But when I look again into this stuff then I see for example "short > address setting". The parameter in cfg802154 trace is named as "sa" and > in mac802154 shown as "short addr", we should keep the same name for > that (maybe ortiented by driver ops parameter naming). Got it. Thanks, -- Varka Bhadram ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH bluetooth-next 3/3] ieee802154: trace: fix extended addr format specifier 2015-06-01 4:33 [PATCH bluetooth-next 0/3] rdev-ops trace fixes Varka Bhadram 2015-06-01 4:33 ` [PATCH bluetooth-next 1/3] ieee802154: trace: fix name for tx power value Varka Bhadram 2015-06-01 4:33 ` [PATCH bluetooth-next 2/3] ieee802154: trace: fix name for extended address Varka Bhadram @ 2015-06-01 4:33 ` Varka Bhadram 2 siblings, 0 replies; 7+ messages in thread From: Varka Bhadram @ 2015-06-01 4:33 UTC (permalink / raw) To: linux-wpan; +Cc: alex.aring, Varka Bhadram Signed-off-by: Varka Bhadram <varkab@cdac.in> --- net/ieee802154/trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ieee802154/trace.h b/net/ieee802154/trace.h index 9b5eefc..dce6794 100644 --- a/net/ieee802154/trace.h +++ b/net/ieee802154/trace.h @@ -56,7 +56,7 @@ TRACE_EVENT(802154_rdev_add_virtual_intf, __entry->type = type; __entry->extended_addr = extended_addr; ), - TP_printk(WPAN_PHY_PR_FMT ", virtual intf name: %s, type: %d, extended addr: %llx", + TP_printk(WPAN_PHY_PR_FMT ", virtual intf name: %s, type: %d, extended addr: 0x%llx", WPAN_PHY_PR_ARG, __get_str(vir_intf_name), __entry->type, __le64_to_cpu(__entry->extended_addr)) ); -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-06-01 8:42 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-06-01 4:33 [PATCH bluetooth-next 0/3] rdev-ops trace fixes Varka Bhadram 2015-06-01 4:33 ` [PATCH bluetooth-next 1/3] ieee802154: trace: fix name for tx power value Varka Bhadram 2015-06-01 4:33 ` [PATCH bluetooth-next 2/3] ieee802154: trace: fix name for extended address Varka Bhadram 2015-06-01 7:37 ` Stefan Schmidt 2015-06-01 8:15 ` Alexander Aring 2015-06-01 8:41 ` Varka Bhadram 2015-06-01 4:33 ` [PATCH bluetooth-next 3/3] ieee802154: trace: fix extended addr format specifier Varka Bhadram
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.