All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Paolo Bonzini <pbonzini@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	mrezanin@redhat.com
Cc: pmatouse@redhat.com, qemu-devel@nongnu.org,
	P J P <pjp@fedoraproject.org>
Subject: Re: [Qemu-devel] [PATCH] net: fix insecure temporary file creation in SLiRP
Date: Mon, 01 Jun 2015 11:49:03 +0300	[thread overview]
Message-ID: <556C1C7F.40203@msgid.tls.msk.ru> (raw)
In-Reply-To: <556C1C0B.6030209@redhat.com>

01.06.2015 11:47, Paolo Bonzini пишет:
> 
> 
> On 01/06/2015 09:58, Markus Armbruster wrote:
>>>> -    snprintf(s->smb_dir, sizeof(s->smb_dir), "/tmp/qemu-smb.%ld-%d",
>>>> -             (long)getpid(), instance++);
>>>> -    if (mkdir(s->smb_dir, 0700) < 0) {
>>>> -        error_report("could not create samba server dir '%s'", s->smb_dir);
>>>> +    if (!(tmpdir = mkdtemp(smb_dir))) {
> 
> mkdtemp is unfortunately missing on Windows, and g_mkdtemp requires glib
> 2.30.

This code is within #ifndef WIN32 block.

/mjt

  reply	other threads:[~2015-06-01  8:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-01  7:06 [Qemu-devel] [PATCH] net: fix insecure temporary file creation in SLiRP mrezanin
2015-06-01  7:58 ` Markus Armbruster
2015-06-01  8:38   ` Miroslav Rezanina
2015-06-01  8:47   ` Paolo Bonzini
2015-06-01  8:49     ` Michael Tokarev [this message]
2015-06-02  6:51   ` P J P
2015-06-03 11:03     ` Markus Armbruster
2015-06-04  4:29       ` P J P

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=556C1C7F.40203@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=armbru@redhat.com \
    --cc=mrezanin@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=pjp@fedoraproject.org \
    --cc=pmatouse@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.