From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40576) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzNNs-0000T9-L4 for qemu-devel@nongnu.org; Mon, 01 Jun 2015 06:55:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzNNq-0007Vq-Pn for qemu-devel@nongnu.org; Mon, 01 Jun 2015 06:55:56 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:24833) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzNNq-0007Vj-J9 for qemu-devel@nongnu.org; Mon, 01 Jun 2015 06:55:54 -0400 Message-ID: <556C2916.7000609@imgtec.com> Date: Mon, 1 Jun 2015 10:42:46 +0100 From: Yongbok Kim MIME-Version: 1.0 References: <1432920900-11047-1-git-send-email-rth@twiddle.net> In-Reply-To: <1432920900-11047-1-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] tcg: Mask TCGMemOp appropriately for indexing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , qemu-devel@nongnu.org On 29/05/2015 18:35, Richard Henderson wrote: > The addition of MO_AMASK means that places that used inverted masks > need to be changed to use positive masks, and places that failed to > mask the intended bits need updating. > > Cc: Yongbok Kim > Signed-off-by: Richard Henderson > --- > > This should fix the problem you found while testing the mipsr6 > unaligned memory ops patch set. > > > r~ I have noticed that you haven't changed it for the tci, is it deliberate? Another minor thing is that tcg_dump_ops() in tcg.c wouldn't print ld/st names correctly but hex code will be printed out. Otherwise, Reviewed-by: Yongbok Kim Regards, Yongbok