From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen/arm: gic-hip04: Resync the driver with the GICv2 Date: Mon, 1 Jun 2015 13:11:13 +0100 Message-ID: <556C4BE1.9090508@citrix.com> References: <1430938350-23985-1-git-send-email-julien.grall@citrix.com> <554B27D9.6020104@linaro.org> <1430991151.2660.343.camel@citrix.com> <554B5C71.3020007@linaro.org> <55566052.1000500@citrix.com> <5559EAD3.7030000@linaro.org> <556C3E4D.1080304@citrix.com> <556C4133.6060703@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YzOZL-0004ec-If for xen-devel@lists.xenproject.org; Mon, 01 Jun 2015 12:11:51 +0000 In-Reply-To: <556C4133.6060703@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Zoltan Kiss , Julien Grall , Ian Campbell Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com, tim@xen.org, Shameerali Kolothum Thodi , Zoltan Kiss List-Id: xen-devel@lists.xenproject.org On 01/06/15 12:25, Zoltan Kiss wrote: > Hi, > > Yes, we managed to test it, and it works. Then only thing I've found is > this bit: > > + /* Only 1020 interrupts are supported */ > + gicv2_info.nr_lines = min(1020U, nr_lines); > > This interrupt controller only supports 511, so 1020 should be replaced. > We had such checking in the code in the early versions, and I looked > everywhere in the archives to figure out why it was dropped before > upstreaming, but I couldn't find it. I'm aware of the 512 limit (see comment on the patch [1]). This change was introduced on GICv2/GICv3 because the nr_lines will always be aligned to 32, although IRQ 1020-1023 are reserved. 512 is a multiple of 32 and unless you have reserved IRQ below 512 and/or your GIC doesn't expose the right number of IRQ, this doesn't harm and keep the change limited. > Other than this bit: > > Reviewed-by: Zoltan Kiss > Tested-by: Shameerali Kolothum Thodi Thanks. Can I get some Acked/Review on the other pending patch series? http://lists.xenproject.org/archives/html/xen-devel/2015-05/msg00944.html : 6 patches to ack. Regards, [1] https://patches.linaro.org/46100/ -- Julien Grall