From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzQSi-0006EX-9Q for qemu-devel@nongnu.org; Mon, 01 Jun 2015 10:13:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzQSe-0002x5-6b for qemu-devel@nongnu.org; Mon, 01 Jun 2015 10:13:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48278) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzQSe-0002x1-14 for qemu-devel@nongnu.org; Mon, 01 Jun 2015 10:13:04 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id BE73839F534 for ; Mon, 1 Jun 2015 14:13:03 +0000 (UTC) Message-ID: <556C686C.3090407@redhat.com> Date: Mon, 01 Jun 2015 17:13:00 +0300 From: Marcel Apfelbaum MIME-Version: 1.0 References: <1433167752-5311-1-git-send-email-marcel@redhat.com> In-Reply-To: <1433167752-5311-1-git-send-email-marcel@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] hw/q35: fix floppy controller definition in ich9 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, jsnow@redhat.com, kraxel@redhat.com, mst@redhat.com On 06/01/2015 05:09 PM, Marcel Apfelbaum wrote: > In DSDT FDC0 declares the IO region as IO(Decode16, 0x03F2, 0x03F2, 0x00, 0x04). > Use the same in lpc_ich9 initialization code. > Now the floppy drive is detected correctly on Windows. > > Signed-off-by: Marcel Apfelbaum > --- > hw/isa/lpc_ich9.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c > index dba7585..bc9afc6 100644 > --- a/hw/isa/lpc_ich9.c > +++ b/hw/isa/lpc_ich9.c > @@ -494,7 +494,7 @@ static void ich9_lpc_machine_ready(Notifier *n, void *opaque) > /* lpt */ > pci_conf[0x82] |= 0x04; > } > - if (memory_region_present(io_as, 0x3f0)) { > + if (memory_region_present(io_as, 0x3f2)) { > /* floppy */ > pci_conf[0x82] |= 0x08; > } > Hi, I cc-ed the developers involved in the mail thread: https://lists.gnu.org/archive/html/qemu-block/2015-05/msg01043.html and the FDC maintainer. I hope I didn't miss anybody. I also have no knowledge of FDC, but I think the above patch is correct and solves the problem of floppy disk missing in Windows for Q35 machines. Comments appreciated as always. Thanks, Marcel