From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzRIS-00043y-Bw for qemu-devel@nongnu.org; Mon, 01 Jun 2015 11:06:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzRIK-0004Zo-9S for qemu-devel@nongnu.org; Mon, 01 Jun 2015 11:06:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45874) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzRIK-0004ZY-2M for qemu-devel@nongnu.org; Mon, 01 Jun 2015 11:06:28 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 88CD68F293 for ; Mon, 1 Jun 2015 15:06:27 +0000 (UTC) Message-ID: <556C74F0.7040605@redhat.com> Date: Mon, 01 Jun 2015 18:06:24 +0300 From: Marcel Apfelbaum MIME-Version: 1.0 References: <1433167752-5311-1-git-send-email-marcel@redhat.com> <556C686C.3090407@redhat.com> <556C6FFE.6000803@redhat.com> <556C7234.6090300@redhat.com> <938219099.12500567.1433170675854.JavaMail.zimbra@redhat.com> In-Reply-To: <938219099.12500567.1433170675854.JavaMail.zimbra@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] hw/q35: fix floppy controller definition in ich9 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , mst@redhat.com Cc: jsnow@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com On 06/01/2015 05:57 PM, Paolo Bonzini wrote: >> On 06/01/2015 05:45 PM, Paolo Bonzini wrote: >>> The patch is okay, but the correct definition of the area is from 0x3F1 >>> to 0x3F7. >> Can we do other fixes on top of this? This patch solves the actual Windows >> problem and now we can use floppies for Q35. > > Well, IANAM. :) > >> Can I take this okay as a "Reviewed-by"? ) > > Sure. Thanks Paolo! Michael, maybe you can take this patch under pci/Q35 branch? Thanks, Marcel > > Paolo >