From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Linux Kernel Developers List <linux-kernel@vger.kernel.org>,
keescook@chromium.org, jwboyer@redhat.com, richard@nod.at,
steved@redhat.com, qat-linux@intel.com, dhowells@redhat.com,
linux-crypto@vger.kernel.org, james.l.morris@oracle.com,
jkosina@suse.cz, zohar@linux.vnet.ibm.com, davem@davemloft.net,
vgoyal@redhat.com
Subject: Re: [PATCH RFC v2 1/2] crypto: add PKE API
Date: Mon, 01 Jun 2015 10:52:24 -0700 [thread overview]
Message-ID: <556C9BD8.3050709@intel.com> (raw)
In-Reply-To: <20150601054857.GA10460@gondor.apana.org.au>
On 05/31/2015 10:48 PM, Herbert Xu wrote:
> On Thu, May 28, 2015 at 09:54:41AM -0700, Tadeusz Struk wrote:
>>
>> If we do this that way then we will be able to pass only one input and one
>> output parameter. There are cases when we will need more that this.
>> For instance for ECDSA signature generation we need one input param hash(m)
>> and two output parameters (r, s).
>
> There is no reason why you couldn't encode that within one stream.
> As far as as the user is concerned the output is one entity, i.e.,
> the signature. The fact that it is made up of two numbers is of
> no concern to the API. It's a technicality for the algorithm to
> sort out.
>
>> So I have used the SG for that. This is not to deal with non-contiguous memory,
>> but to pass more in/out parameters. Each parameter will need to occupy contiguous space in memory.
>> I will update the comment to make it more clear.
>> If you have other idea how to do this I will be happy to try it.
>
> If you really wanted to do this then you should be using a simple
> (u8 *, unsigned int) pair but I don't really think this is at all
> necessary.
>
Ok, I'll rework this to take one char *src and one *dst ptrs.
Thanks
T
next prev parent reply other threads:[~2015-06-01 17:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 19:36 [PATCH RFC v2 0/2] crypto: Introduce Public Key Encryption API Tadeusz Struk
2015-05-06 19:36 ` [PATCH RFC v2 1/2] crypto: add PKE API Tadeusz Struk
2015-05-11 6:03 ` Herbert Xu
2015-05-11 6:24 ` Herbert Xu
2015-05-11 13:45 ` David Howells
2015-05-12 1:21 ` Herbert Xu
2015-05-13 15:03 ` David Howells
2015-05-14 2:59 ` Herbert Xu
2015-05-11 6:27 ` Herbert Xu
2015-05-11 6:32 ` Herbert Xu
2015-05-22 18:37 ` Tadeusz Struk
2015-05-23 5:47 ` Herbert Xu
2015-05-23 14:20 ` Tadeusz Struk
2015-05-28 4:08 ` Herbert Xu
2015-05-28 16:54 ` Tadeusz Struk
2015-06-01 5:48 ` Herbert Xu
2015-06-01 17:52 ` Tadeusz Struk [this message]
2015-06-08 19:34 ` Kees Cook
2015-05-06 19:36 ` [PATCH RFC v2 2/2] crypto: RSA: KEYS: convert rsa and public key to new " Tadeusz Struk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556C9BD8.3050709@intel.com \
--to=tadeusz.struk@intel.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=james.l.morris@oracle.com \
--cc=jkosina@suse.cz \
--cc=jwboyer@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qat-linux@intel.com \
--cc=richard@nod.at \
--cc=steved@redhat.com \
--cc=vgoyal@redhat.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.