From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga03-in.huawei.com ([119.145.14.66]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YzaF0-0008D9-Bg for linux-mtd@lists.infradead.org; Tue, 02 Jun 2015 00:39:39 +0000 Message-ID: <556CFB0D.6030805@huawei.com> Date: Tue, 2 Jun 2015 08:38:37 +0800 From: Sheng Yong MIME-Version: 1.0 To: Subject: Re: [RFC PATCH v2 0/6] UBI: Some cleanup and check if a vol exists when fastmap attaching References: <1432634830-129590-1-git-send-email-shengyong1@huawei.com> In-Reply-To: <1432634830-129590-1-git-send-email-shengyong1@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: linux-mtd@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Ping. On 5/26/2015 6:07 PM, Sheng Yong wrote: > Hi, folks, > > V2: > * change the commit message of PATCH 5. In normal cases, including unclean > reboot and ECC scenario, there is no way to have two same vol_id saved in > different slots in ubi->volumes[], so add_vol() in fastmap attach won't > go wrong. Only if the on-flash fastmap is modified by hand, this issue > may be triggered. > Thanks Richard Weinberger for pointing this out. > > * add two more cleanup. > . add a helper function for updatting on-flash layout volumes. No > semantic changes. > > V1: > http://lists.infradead.org/pipermail/linux-mtd/2015-May/059355.html > > Thanks, > Sheng > > Sheng Yong (6): > UBI: Fastmap: Use max() to get the larger value > UBI: Fastmap: Remove unnecessary `\' > UBI: Fastmap: Rename variables to make them meaningful > UBI: Init vol->reserved_pebs by assignment > UBI: Fastmap: Do not add vol if it already exists > UBI: add a helper function for updatting on-flash layout volumes > > drivers/mtd/ubi/build.c | 4 +-- > drivers/mtd/ubi/fastmap.c | 81 +++++++++++++++++++++++++---------------------- > drivers/mtd/ubi/vmt.c | 4 +-- > drivers/mtd/ubi/vtbl.c | 45 ++++++++++++++------------ > 4 files changed, 72 insertions(+), 62 deletions(-) >