From: Timo Aaltonen <tjaalton@ubuntu.com>
To: Daniel Vetter <daniel@ffwll.ch>, Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915/skl: changed the filename of csr firmware
Date: Tue, 02 Jun 2015 11:13:11 +0300 [thread overview]
Message-ID: <556D6597.4040007@ubuntu.com> (raw)
In-Reply-To: <20150527113405.GG8341@phenom.ffwll.local>
On 27.05.2015 14:34, Daniel Vetter wrote:
> On Tue, May 26, 2015 at 05:21:56PM -0700, Rodrigo Vivi wrote:
>> On Thu, May 21, 2015 at 5:04 AM, Animesh Manna <animesh.manna@intel.com> wrote:
>>> Naming convention of csr firmware will be -
>>> <platform>_dmc_<api-version>_<minor-version>.bin
>>>
>>> Accordingly updated the same in code.
>>>
>>> Signed-off-by: Animesh Manna <animesh.manna@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/intel_csr.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
>>> index fec2bc5..9bd05bf 100644
>>> --- a/drivers/gpu/drm/i915/intel_csr.c
>>> +++ b/drivers/gpu/drm/i915/intel_csr.c
>>> @@ -34,7 +34,7 @@
>>> * low-power state and comes back to normal.
>>> */
>>>
>>> -#define I915_CSR_SKL "i915/skl_dmc_ver4.bin"
>>> +#define I915_CSR_SKL "i915/skl_dmc_1_4.bin"
>>
>> I believe in this case the install instructions should point to copy
>> instead of linking it, but not hardcode the release version.
>>
>> So shouldn't it be i915/skl_dmc_ver1.bin then?
>>
>> or i915/skl_dmc_ver1_4.bin in worst case...
>
> While at it, can we perhaps _not_ hardcode the minor revision? Hardcoding
> the minor revision torpedoes the entire concept of even having a minor
> revision. If the firmware team can't do proper abi versioning, then imo we
> should just put one number for each and keep it at that.
> -Daniel
Can we please settle on something? I'd rather have the csr fw in
linux-firmware quite soon, so that the driver wouldn't give an ugly
assert when csr doesn't work.
--
t
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-06-02 8:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 12:04 [PATCH] drm/i915/skl: changed the filename of csr firmware Animesh Manna
2015-05-27 0:21 ` Rodrigo Vivi
2015-05-27 11:34 ` Daniel Vetter
2015-06-02 8:13 ` Timo Aaltonen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556D6597.4040007@ubuntu.com \
--to=tjaalton@ubuntu.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.