diff for duplicates of <556D6CB4.30900@topic.nl> diff --git a/a/1.txt b/N1/1.txt index f5d5239..f14a82d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,4 +1,4 @@ -=EF=BB=BFOn 02-06-15 09:50, Paul Bolle wrote: +On 02-06-15 09:50, Paul Bolle wrote: > On Mon, 2015-06-01 at 12:13 +0200, Mike Looijmans wrote: >> --- /dev/null >> +++ b/drivers/clk/clk-cdce925.c @@ -12,49 +12,39 @@ > For some silly reason (ie, I mistakenly thought I spotted an issue) I > did a quick build of this file. That triggered some noise on x86_64. -Indeed, I hadn't verified building on a 64-bit platform, and the format str= -ing=20 +Indeed, I hadn't verified building on a 64-bit platform, and the format string is incorrect. -Thanks for spotting it and suggesting a fix, I'll integrate it in a v4 patc= -h. +Thanks for spotting it and suggesting a fix, I'll integrate it in a v4 patch. -Out of curiousity, I did try a compile on the x86 host, but couldn't select= -=20 -the driver because it depends on CONFIG_OF, so I just compiled if for the A= -RM=20 -target to verify that it still compiles in kernel 4.1. How did you manage t= -o=20 +Out of curiousity, I did try a compile on the x86 host, but couldn't select +the driver because it depends on CONFIG_OF, so I just compiled if for the ARM +target to verify that it still compiles in kernel 4.1. How did you manage to compile the driver on the x86? > Excerpt: > -> drivers/clk/clk-cdce925.c: In function =E2=80=98cdce925_regmap_i2c_write= -=E2=80=99: -> include/linux/dynamic_debug.h:64:16: warning: format =E2=80=98%u=E2=80=99= - expects argument of type =E2=80=98unsigned int=E2=80=99, but argument 5 ha= -s type =E2=80=98size_t=E2=80=99 [-Wformat=3D] +> drivers/clk/clk-cdce925.c: In function ‘cdce925_regmap_i2c_write’: +> include/linux/dynamic_debug.h:64:16: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 5 has type ‘size_t’ [-Wformat=] > static struct _ddebug __aligned(8) \ > ^ > [...] -> drivers/clk/clk-cdce925.c:505:2: note: in expansion of macro =E2=80=98dev= -_dbg=E2=80=99 +> drivers/clk/clk-cdce925.c:505:2: note: in expansion of macro ‘dev_dbg’ > dev_dbg(&i2c->dev, "%s(%u) %#x %#x\n", __func__, count, > ^ > > A quick look at Documentation/printk-formats.txt suggested this (very > lightly tested) fix: > @@ -502,7 +502,7 @@ static int cdce925_regmap_i2c_write( -> reg_data[0] =3D CDCE925_I2C_COMMAND_BYTE_TRANSFER | ((u8 *)data)= -[0]; -> reg_data[1] =3D ((u8 *)data)[1]; +> reg_data[0] = CDCE925_I2C_COMMAND_BYTE_TRANSFER | ((u8 *)data)[0]; +> reg_data[1] = ((u8 *)data)[1]; > > - dev_dbg(&i2c->dev, "%s(%u) %#x %#x\n", __func__, count, > + dev_dbg(&i2c->dev, "%s(%zu) %#x %#x\n", __func__, count, > reg_data[0], reg_data[1]); > -> ret =3D i2c_master_send(i2c, reg_data, count); +> ret = i2c_master_send(i2c, reg_data, count); > >> +static int cdce925_regmap_i2c_read(void *context, >> + const void *reg, size_t reg_size, void *val, size_t val_size) @@ -65,12 +55,11 @@ _dbg=E2=80=99 > Likewise: > @@ -547,7 +547,7 @@ static int cdce925_regmap_i2c_read(void *context, > -> ret =3D i2c_transfer(i2c->adapter, xfer, 2); -> if (likely(ret =3D=3D 2)) { +> ret = i2c_transfer(i2c->adapter, xfer, 2); +> if (likely(ret == 2)) { > - dev_dbg(&i2c->dev, "%s(%u, %u) %#x %#x\n", __func__, > + dev_dbg(&i2c->dev, "%s(%zu, %zu) %#x %#x\n", __func__, -> reg_size, val_size, reg_data[0], *((u8 *= -)val)); +> reg_size, val_size, reg_data[0], *((u8 *)val)); > return 0; > } else if (ret < 0) > diff --git a/a/content_digest b/N1/content_digest index a56ef75..ec670f1 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,14 +4,14 @@ "Subject\0Re: [PATCH v3] Add TI CDCE925 I2C controlled clock synthesizer driver\0" "Date\0Tue, 2 Jun 2015 10:43:32 +0200\0" "To\0Paul Bolle <pebolle@tiscali.nl>\0" - "Cc\0<linux-clk@vger.kernel.org>" - <sboyd@codeaurora.org> - <mturquette@linaro.org> - <linux-kernel@vger.kernel.org> - " <devicetree@vger.kernel.org>\0" + "Cc\0linux-clk@vger.kernel.org" + sboyd@codeaurora.org + mturquette@linaro.org + linux-kernel@vger.kernel.org + " devicetree@vger.kernel.org\0" "\00:1\0" "b\0" - "=EF=BB=BFOn 02-06-15 09:50, Paul Bolle wrote:\n" + "\357\273\277On 02-06-15 09:50, Paul Bolle wrote:\n" "> On Mon, 2015-06-01 at 12:13 +0200, Mike Looijmans wrote:\n" ">> --- /dev/null\n" ">> +++ b/drivers/clk/clk-cdce925.c\n" @@ -25,49 +25,39 @@ "> For some silly reason (ie, I mistakenly thought I spotted an issue) I\n" "> did a quick build of this file. That triggered some noise on x86_64.\n" "\n" - "Indeed, I hadn't verified building on a 64-bit platform, and the format str=\n" - "ing=20\n" + "Indeed, I hadn't verified building on a 64-bit platform, and the format string \n" "is incorrect.\n" "\n" - "Thanks for spotting it and suggesting a fix, I'll integrate it in a v4 patc=\n" - "h.\n" + "Thanks for spotting it and suggesting a fix, I'll integrate it in a v4 patch.\n" "\n" - "Out of curiousity, I did try a compile on the x86 host, but couldn't select=\n" - "=20\n" - "the driver because it depends on CONFIG_OF, so I just compiled if for the A=\n" - "RM=20\n" - "target to verify that it still compiles in kernel 4.1. How did you manage t=\n" - "o=20\n" + "Out of curiousity, I did try a compile on the x86 host, but couldn't select \n" + "the driver because it depends on CONFIG_OF, so I just compiled if for the ARM \n" + "target to verify that it still compiles in kernel 4.1. How did you manage to \n" "compile the driver on the x86?\n" "\n" "\n" "> Excerpt:\n" ">\n" - "> drivers/clk/clk-cdce925.c: In function =E2=80=98cdce925_regmap_i2c_write=\n" - "=E2=80=99:\n" - "> include/linux/dynamic_debug.h:64:16: warning: format =E2=80=98%u=E2=80=99=\n" - " expects argument of type =E2=80=98unsigned int=E2=80=99, but argument 5 ha=\n" - "s type =E2=80=98size_t=E2=80=99 [-Wformat=3D]\n" + "> drivers/clk/clk-cdce925.c: In function \342\200\230cdce925_regmap_i2c_write\342\200\231:\n" + "> include/linux/dynamic_debug.h:64:16: warning: format \342\200\230%u\342\200\231 expects argument of type \342\200\230unsigned int\342\200\231, but argument 5 has type \342\200\230size_t\342\200\231 [-Wformat=]\n" "> static struct _ddebug __aligned(8) \\\n" "> ^\n" "> [...]\n" - "> drivers/clk/clk-cdce925.c:505:2: note: in expansion of macro =E2=80=98dev=\n" - "_dbg=E2=80=99\n" + "> drivers/clk/clk-cdce925.c:505:2: note: in expansion of macro \342\200\230dev_dbg\342\200\231\n" "> dev_dbg(&i2c->dev, \"%s(%u) %#x %#x\\n\", __func__, count,\n" "> ^\n" ">\n" "> A quick look at Documentation/printk-formats.txt suggested this (very\n" "> lightly tested) fix:\n" "> @@ -502,7 +502,7 @@ static int cdce925_regmap_i2c_write(\n" - "> reg_data[0] =3D CDCE925_I2C_COMMAND_BYTE_TRANSFER | ((u8 *)data)=\n" - "[0];\n" - "> reg_data[1] =3D ((u8 *)data)[1];\n" + "> reg_data[0] = CDCE925_I2C_COMMAND_BYTE_TRANSFER | ((u8 *)data)[0];\n" + "> reg_data[1] = ((u8 *)data)[1];\n" ">\n" "> - dev_dbg(&i2c->dev, \"%s(%u) %#x %#x\\n\", __func__, count,\n" "> + dev_dbg(&i2c->dev, \"%s(%zu) %#x %#x\\n\", __func__, count,\n" "> reg_data[0], reg_data[1]);\n" ">\n" - "> ret =3D i2c_master_send(i2c, reg_data, count);\n" + "> ret = i2c_master_send(i2c, reg_data, count);\n" ">\n" ">> +static int cdce925_regmap_i2c_read(void *context,\n" ">> +\t const void *reg, size_t reg_size, void *val, size_t val_size)\n" @@ -78,12 +68,11 @@ "> Likewise:\n" "> @@ -547,7 +547,7 @@ static int cdce925_regmap_i2c_read(void *context,\n" ">\n" - "> ret =3D i2c_transfer(i2c->adapter, xfer, 2);\n" - "> if (likely(ret =3D=3D 2)) {\n" + "> ret = i2c_transfer(i2c->adapter, xfer, 2);\n" + "> if (likely(ret == 2)) {\n" "> - dev_dbg(&i2c->dev, \"%s(%u, %u) %#x %#x\\n\", __func__,\n" "> + dev_dbg(&i2c->dev, \"%s(%zu, %zu) %#x %#x\\n\", __func__,\n" - "> reg_size, val_size, reg_data[0], *((u8 *=\n" - ")val));\n" + "> reg_size, val_size, reg_data[0], *((u8 *)val));\n" "> return 0;\n" "> } else if (ret < 0)\n" ">\n" @@ -110,4 +99,4 @@ "\n" Please consider the environment before printing this e-mail -914478c461394412da50408fa57cf9789621c933e077f69a9365c865e0abdd4e +a0912480979d1b2ea1d665fca5342800c314d481cc3bb88a8b69eea0d8855a19
diff --git a/a/1.txt b/N2/1.txt index f5d5239..f14a82d 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,4 +1,4 @@ -=EF=BB=BFOn 02-06-15 09:50, Paul Bolle wrote: +On 02-06-15 09:50, Paul Bolle wrote: > On Mon, 2015-06-01 at 12:13 +0200, Mike Looijmans wrote: >> --- /dev/null >> +++ b/drivers/clk/clk-cdce925.c @@ -12,49 +12,39 @@ > For some silly reason (ie, I mistakenly thought I spotted an issue) I > did a quick build of this file. That triggered some noise on x86_64. -Indeed, I hadn't verified building on a 64-bit platform, and the format str= -ing=20 +Indeed, I hadn't verified building on a 64-bit platform, and the format string is incorrect. -Thanks for spotting it and suggesting a fix, I'll integrate it in a v4 patc= -h. +Thanks for spotting it and suggesting a fix, I'll integrate it in a v4 patch. -Out of curiousity, I did try a compile on the x86 host, but couldn't select= -=20 -the driver because it depends on CONFIG_OF, so I just compiled if for the A= -RM=20 -target to verify that it still compiles in kernel 4.1. How did you manage t= -o=20 +Out of curiousity, I did try a compile on the x86 host, but couldn't select +the driver because it depends on CONFIG_OF, so I just compiled if for the ARM +target to verify that it still compiles in kernel 4.1. How did you manage to compile the driver on the x86? > Excerpt: > -> drivers/clk/clk-cdce925.c: In function =E2=80=98cdce925_regmap_i2c_write= -=E2=80=99: -> include/linux/dynamic_debug.h:64:16: warning: format =E2=80=98%u=E2=80=99= - expects argument of type =E2=80=98unsigned int=E2=80=99, but argument 5 ha= -s type =E2=80=98size_t=E2=80=99 [-Wformat=3D] +> drivers/clk/clk-cdce925.c: In function ‘cdce925_regmap_i2c_write’: +> include/linux/dynamic_debug.h:64:16: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 5 has type ‘size_t’ [-Wformat=] > static struct _ddebug __aligned(8) \ > ^ > [...] -> drivers/clk/clk-cdce925.c:505:2: note: in expansion of macro =E2=80=98dev= -_dbg=E2=80=99 +> drivers/clk/clk-cdce925.c:505:2: note: in expansion of macro ‘dev_dbg’ > dev_dbg(&i2c->dev, "%s(%u) %#x %#x\n", __func__, count, > ^ > > A quick look at Documentation/printk-formats.txt suggested this (very > lightly tested) fix: > @@ -502,7 +502,7 @@ static int cdce925_regmap_i2c_write( -> reg_data[0] =3D CDCE925_I2C_COMMAND_BYTE_TRANSFER | ((u8 *)data)= -[0]; -> reg_data[1] =3D ((u8 *)data)[1]; +> reg_data[0] = CDCE925_I2C_COMMAND_BYTE_TRANSFER | ((u8 *)data)[0]; +> reg_data[1] = ((u8 *)data)[1]; > > - dev_dbg(&i2c->dev, "%s(%u) %#x %#x\n", __func__, count, > + dev_dbg(&i2c->dev, "%s(%zu) %#x %#x\n", __func__, count, > reg_data[0], reg_data[1]); > -> ret =3D i2c_master_send(i2c, reg_data, count); +> ret = i2c_master_send(i2c, reg_data, count); > >> +static int cdce925_regmap_i2c_read(void *context, >> + const void *reg, size_t reg_size, void *val, size_t val_size) @@ -65,12 +55,11 @@ _dbg=E2=80=99 > Likewise: > @@ -547,7 +547,7 @@ static int cdce925_regmap_i2c_read(void *context, > -> ret =3D i2c_transfer(i2c->adapter, xfer, 2); -> if (likely(ret =3D=3D 2)) { +> ret = i2c_transfer(i2c->adapter, xfer, 2); +> if (likely(ret == 2)) { > - dev_dbg(&i2c->dev, "%s(%u, %u) %#x %#x\n", __func__, > + dev_dbg(&i2c->dev, "%s(%zu, %zu) %#x %#x\n", __func__, -> reg_size, val_size, reg_data[0], *((u8 *= -)val)); +> reg_size, val_size, reg_data[0], *((u8 *)val)); > return 0; > } else if (ret < 0) > diff --git a/a/content_digest b/N2/content_digest index a56ef75..75f5b84 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -11,7 +11,7 @@ " <devicetree@vger.kernel.org>\0" "\00:1\0" "b\0" - "=EF=BB=BFOn 02-06-15 09:50, Paul Bolle wrote:\n" + "\357\273\277On 02-06-15 09:50, Paul Bolle wrote:\n" "> On Mon, 2015-06-01 at 12:13 +0200, Mike Looijmans wrote:\n" ">> --- /dev/null\n" ">> +++ b/drivers/clk/clk-cdce925.c\n" @@ -25,49 +25,39 @@ "> For some silly reason (ie, I mistakenly thought I spotted an issue) I\n" "> did a quick build of this file. That triggered some noise on x86_64.\n" "\n" - "Indeed, I hadn't verified building on a 64-bit platform, and the format str=\n" - "ing=20\n" + "Indeed, I hadn't verified building on a 64-bit platform, and the format string \n" "is incorrect.\n" "\n" - "Thanks for spotting it and suggesting a fix, I'll integrate it in a v4 patc=\n" - "h.\n" + "Thanks for spotting it and suggesting a fix, I'll integrate it in a v4 patch.\n" "\n" - "Out of curiousity, I did try a compile on the x86 host, but couldn't select=\n" - "=20\n" - "the driver because it depends on CONFIG_OF, so I just compiled if for the A=\n" - "RM=20\n" - "target to verify that it still compiles in kernel 4.1. How did you manage t=\n" - "o=20\n" + "Out of curiousity, I did try a compile on the x86 host, but couldn't select \n" + "the driver because it depends on CONFIG_OF, so I just compiled if for the ARM \n" + "target to verify that it still compiles in kernel 4.1. How did you manage to \n" "compile the driver on the x86?\n" "\n" "\n" "> Excerpt:\n" ">\n" - "> drivers/clk/clk-cdce925.c: In function =E2=80=98cdce925_regmap_i2c_write=\n" - "=E2=80=99:\n" - "> include/linux/dynamic_debug.h:64:16: warning: format =E2=80=98%u=E2=80=99=\n" - " expects argument of type =E2=80=98unsigned int=E2=80=99, but argument 5 ha=\n" - "s type =E2=80=98size_t=E2=80=99 [-Wformat=3D]\n" + "> drivers/clk/clk-cdce925.c: In function \342\200\230cdce925_regmap_i2c_write\342\200\231:\n" + "> include/linux/dynamic_debug.h:64:16: warning: format \342\200\230%u\342\200\231 expects argument of type \342\200\230unsigned int\342\200\231, but argument 5 has type \342\200\230size_t\342\200\231 [-Wformat=]\n" "> static struct _ddebug __aligned(8) \\\n" "> ^\n" "> [...]\n" - "> drivers/clk/clk-cdce925.c:505:2: note: in expansion of macro =E2=80=98dev=\n" - "_dbg=E2=80=99\n" + "> drivers/clk/clk-cdce925.c:505:2: note: in expansion of macro \342\200\230dev_dbg\342\200\231\n" "> dev_dbg(&i2c->dev, \"%s(%u) %#x %#x\\n\", __func__, count,\n" "> ^\n" ">\n" "> A quick look at Documentation/printk-formats.txt suggested this (very\n" "> lightly tested) fix:\n" "> @@ -502,7 +502,7 @@ static int cdce925_regmap_i2c_write(\n" - "> reg_data[0] =3D CDCE925_I2C_COMMAND_BYTE_TRANSFER | ((u8 *)data)=\n" - "[0];\n" - "> reg_data[1] =3D ((u8 *)data)[1];\n" + "> reg_data[0] = CDCE925_I2C_COMMAND_BYTE_TRANSFER | ((u8 *)data)[0];\n" + "> reg_data[1] = ((u8 *)data)[1];\n" ">\n" "> - dev_dbg(&i2c->dev, \"%s(%u) %#x %#x\\n\", __func__, count,\n" "> + dev_dbg(&i2c->dev, \"%s(%zu) %#x %#x\\n\", __func__, count,\n" "> reg_data[0], reg_data[1]);\n" ">\n" - "> ret =3D i2c_master_send(i2c, reg_data, count);\n" + "> ret = i2c_master_send(i2c, reg_data, count);\n" ">\n" ">> +static int cdce925_regmap_i2c_read(void *context,\n" ">> +\t const void *reg, size_t reg_size, void *val, size_t val_size)\n" @@ -78,12 +68,11 @@ "> Likewise:\n" "> @@ -547,7 +547,7 @@ static int cdce925_regmap_i2c_read(void *context,\n" ">\n" - "> ret =3D i2c_transfer(i2c->adapter, xfer, 2);\n" - "> if (likely(ret =3D=3D 2)) {\n" + "> ret = i2c_transfer(i2c->adapter, xfer, 2);\n" + "> if (likely(ret == 2)) {\n" "> - dev_dbg(&i2c->dev, \"%s(%u, %u) %#x %#x\\n\", __func__,\n" "> + dev_dbg(&i2c->dev, \"%s(%zu, %zu) %#x %#x\\n\", __func__,\n" - "> reg_size, val_size, reg_data[0], *((u8 *=\n" - ")val));\n" + "> reg_size, val_size, reg_data[0], *((u8 *)val));\n" "> return 0;\n" "> } else if (ret < 0)\n" ">\n" @@ -110,4 +99,4 @@ "\n" Please consider the environment before printing this e-mail -914478c461394412da50408fa57cf9789621c933e077f69a9365c865e0abdd4e +4eff67da8aa0c7cd71429a28545529fb3b9f7e71737f3dae14bd2ab09b7b285c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.