All of lore.kernel.org
 help / color / mirror / Atom feed
From: Goffredo Baroncelli <kreijack@libero.it>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Benjamin Tissoires <benjamin.tissoires@gmail.com>,
	Antonio Ospite <ao2@ao2.it>,
	Nestor Lopez Casado <nlopezcasad@logitech.com>,
	Dario Righelli <drighelli@gmail.com>,
	linux-input@vger.kernel.org,
	Goffredo Baroncelli <kreijack@inwind.it>
Subject: Re: [PATCH 2/2] Add driver for mouse logitech M560
Date: Tue, 02 Jun 2015 14:07:51 +0200	[thread overview]
Message-ID: <556D9C97.7060100@libero.it> (raw)
In-Reply-To: <alpine.LNX.2.00.1506011437270.16120@pobox.suse.cz>

Hi Jiri,

On 2015-06-01 14:39, Jiri Kosina wrote:

> [ ... snip ... ]
>> +		v = hid_snto32(hidpp_field_extract(hdev, data+3, 0, 12), 12);
>> +		input_report_rel(mydata->input, REL_X, v);
>> +
>> +		v = hid_snto32(hidpp_field_extract(hdev, data+3, 12, 12), 12);
>> +		input_report_rel(mydata->input, REL_Y, v);
> 
> There is no hidpp_field_extract() any more in this version of the 
> patchset.
> 
> I've fixed that up and queued in for-4.2/logitech.
> 
I am embarrassed, you are right, I forgot to add these "last minute" changes in 
the git...

Anyway, thanks for the inclusion

BR

-- 
gpg @keyserver.linux.it: Goffredo Baroncelli <kreijackATinwind.it>
Key fingerprint BBF5 1610 0B64 DAC6 5F7D  17B2 0EDA 9B37 8B82 E0B5

      reply	other threads:[~2015-06-02 12:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-30  9:00 [PATCH V6] Add support for mouse logitech m560 Goffredo Baroncelli
2015-05-30  9:00 ` [PATCH 1/2] Export hid_field_extract() Goffredo Baroncelli
2015-05-30  9:00 ` [PATCH 2/2] Add driver for mouse logitech M560 Goffredo Baroncelli
2015-06-01 12:39   ` Jiri Kosina
2015-06-02 12:07     ` Goffredo Baroncelli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=556D9C97.7060100@libero.it \
    --to=kreijack@libero.it \
    --cc=ao2@ao2.it \
    --cc=benjamin.tissoires@gmail.com \
    --cc=drighelli@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=kreijack@inwind.it \
    --cc=linux-input@vger.kernel.org \
    --cc=nlopezcasad@logitech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.