From: Guenter Roeck <linux@roeck-us.net>
To: Johannes Thumshirn <jthumshirn@suse.de>,
Wim Van Sebroeck <wim@iguana.be>
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: mena21_wdt: Fix possible NULL pointer dereference
Date: Tue, 02 Jun 2015 06:44:48 -0700 [thread overview]
Message-ID: <556DB350.4000803@roeck-us.net> (raw)
In-Reply-To: <1433240726-7031-1-git-send-email-jthumshirn@suse.de>
On 06/02/2015 03:25 AM, Johannes Thumshirn wrote:
> In a21_wdt_remove() we do a watchdog_unregister_device() on struct
> a21_wdt_drv->wdt but never assign it.
>
> Also move the dev_set_drvdata() call in front of the watchdog_register_device()
> call, so it doesn't look like an error.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Good catch.
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Guenter
next prev parent reply other threads:[~2015-06-02 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 10:25 [PATCH] watchdog: mena21_wdt: Fix possible NULL pointer dereference Johannes Thumshirn
2015-06-02 13:44 ` Guenter Roeck [this message]
2015-06-22 7:49 ` Johannes Thumshirn
2015-06-22 7:49 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556DB350.4000803@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.