All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@fb.com>
To: Akinobu Mita <akinobu.mita@gmail.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] null_blk: prevent timer handler running on a different CPU where started
Date: Tue, 2 Jun 2015 08:44:09 -0600	[thread overview]
Message-ID: <556DC139.4060805@fb.com> (raw)
In-Reply-To: <1433201710-4284-1-git-send-email-akinobu.mita@gmail.com>

On 06/01/2015 05:35 PM, Akinobu Mita wrote:
> When irqmode=2 (IRQ completion handler is timer), timer handler should
> be called on the same CPU where the timer has been started.
>
> Since completion_queues are per-cpu and the completion handler only
> touches completion_queue for local CPU, we need to prevent the handler
> from running on a different CPU where the timer has been started.
> Otherwise, the IO cannot be completed until another completion handler
> is executed on that CPU.

Thanks, applied this and 2/2, the latter seems to have been forgotten 
after our initial discussion about it.

-- 
Jens Axboe


      parent reply	other threads:[~2015-06-02 14:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-01 23:35 [PATCH 1/2] null_blk: prevent timer handler running on a different CPU where started Akinobu Mita
2015-06-01 23:35 ` [PATCH 2/2] null_blk: restart request processing on completion handler Akinobu Mita
2015-06-02 15:53   ` Akinobu Mita
2015-06-02 14:44 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=556DC139.4060805@fb.com \
    --to=axboe@fb.com \
    --cc=akinobu.mita@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.