From: roopa <roopa@cumulusnetworks.com>
To: David Miller <davem@davemloft.net>
Cc: ebiederm@xmission.com, rshearma@brocade.com,
netdev@vger.kernel.org, vivek@cumulusnetworks.com
Subject: Re: [PATCH net v2 2/2] mpls: fix mpls route deletes to not check for route scope
Date: Tue, 02 Jun 2015 08:35:38 -0700 [thread overview]
Message-ID: <556DCD4A.6050100@cumulusnetworks.com> (raw)
In-Reply-To: <20150601.155838.2219594213274495927.davem@davemloft.net>
On 6/1/15, 3:58 PM, David Miller wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
> Date: Wed, 27 May 2015 11:37:05 -0700
>
>> - if (rtm->rtm_scope != RT_SCOPE_UNIVERSE)
>> - goto errout;
>> + if (nlh->nlmsg_type != RTM_DELROUTE &&
>> + rtm->rtm_scope != RT_SCOPE_UNIVERSE)
>> + goto errout;
>> +
> This is not indented correctly.
>
> When a conditional spans multiple lines, two things must happen:
>
> 1) Each line must end with an operator rather than begin with one.
>
> 2) Each line starting with the second must start exactly at the
> first column after the openning parenthesis of the conditional.
> You must use the appropriate number of TAB then SPACE characters
> necessary to achieve this.
>
sorry, missed this. I have resubmitted the series. thanks.
prev parent reply other threads:[~2015-06-02 15:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 18:37 [PATCH net v2 2/2] mpls: fix mpls route deletes to not check for route scope Roopa Prabhu
2015-05-27 19:46 ` Robert Shearman
2015-06-01 22:58 ` David Miller
2015-06-02 15:35 ` roopa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556DCD4A.6050100@cumulusnetworks.com \
--to=roopa@cumulusnetworks.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
--cc=rshearma@brocade.com \
--cc=vivek@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.