From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yang Hongyang Subject: Re: [PATCH v1 2/5] tools/libxl: move domain suspend codes into a separate file Date: Wed, 3 Jun 2015 00:10:38 +0800 Message-ID: <556DD57E.4090607@cn.fujitsu.com> References: <1432116090-19486-1-git-send-email-yanghy@cn.fujitsu.com> <1432116090-19486-3-git-send-email-yanghy@cn.fujitsu.com> <1433256319.15036.292.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1433256319.15036.292.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: wei.liu2@citrix.com, wency@cn.fujitsu.com, andrew.cooper3@citrix.com, yunhong.jiang@intel.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, rshriram@cs.ubc.ca List-Id: xen-devel@lists.xenproject.org On 06/02/2015 10:45 PM, Ian Campbell wrote: > On Wed, 2015-05-20 at 18:01 +0800, Yang Hongyang wrote: >> diff --git a/tools/libxl/libxl_internal.h >> b/tools/libxl/libxl_internal.h >> index f86fc89..b2eeb89 100644 >> --- a/tools/libxl/libxl_internal.h >> +++ b/tools/libxl/libxl_internal.h >> @@ -3191,6 +3191,12 @@ _hidden void >> libxl__domain_save_device_model(libxl__egc *egc, >> >> _hidden const char *libxl__device_model_savefile(libxl__gc *gc, >> uint32_t domid); >> >> +void libxl__domain_suspend_callback(void *data); >> + >> +/* calls dss->callback_common_done when done */ >> +void libxl__domain_suspend(libxl__egc *egc, >> + libxl__domain_suspend_state *dss); > > Please mark these internal functions _hidden like the other examples in > this file. ok. > > With that the ack I just sent before I notice this stands. > > Ian. > > > . > -- Thanks, Yang.