Re: [Qemu-devel] [PATCH v3 1/4] rocker: Add support for phys name

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1272 bytes --]

On 05/29/2015 08:01 AM, sfeldma@gmail.com wrote:
> From: David Ahern <dsahern@gmail.com>
> 
> v2:
> 
> Review comment from Stefan Hajnoczi:
> 
>  - use private ROCKER_IFNAMSIZ = 16 to avoid breaking Windows build
>    as Windows does not include <net/if.h>
> 
> v1:
> 
> Add ROCKER_TLV_CMD_PORT_SETTINGS_PHYS_NAME to port settings. This attribute
> exports the port name to the guest OS allowing it to name interfaces with
> sensible defaults.

The above patch version information...

> 
> Mostly done by Scott for phys_id support; adapted to phys_name by David.
> 
> Signed-off-by: Scott Feldman <sfeldma@gmail.com>
> Signed-off-by: David Ahern <dsahern@gmail.com>
> ---

...belongs better here, after the --- separator.  'git am' strips off
anything in this location, which makes for a nice separation: anything
before the separator should be stand-alone, but things that are useful
to list readers but not to permanent git history should be after the
separator.  After all, a year from now, we won't care if it took 1 or 10
versions on the list for the patch that got accepted, we will only care
about the one version in git.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]