Re: [PATCH v4 1/9] xentrace: install into sbin

[George Dunlap <george.dunlap@eu.citrix.com>]

On 05/23/2015 09:24 AM, Olaf Hering wrote:
> Collecting the trace buffer requires root permissions. Adjust Makefile
> to install xentrace and xentrace_setsize into sbindir. Leave the
> existing support for BIN in place for upcoming changes.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> Cc: George Dunlap <george.dunlap@eu.citrix.com>

Acked-by: George Dunlap <george.dunlap@eu.citrix.com>

> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> ---
>  tools/xentrace/Makefile | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/xentrace/Makefile b/tools/xentrace/Makefile
> index 8b80541..5360960 100644
> --- a/tools/xentrace/Makefile
> +++ b/tools/xentrace/Makefile
> @@ -6,7 +6,8 @@ CFLAGS += -Werror
>  CFLAGS += $(CFLAGS_libxenctrl)
>  LDLIBS += $(LDLIBS_libxenctrl)
>  
> -BIN      = xentrace xentrace_setsize
> +BIN      =
> +SBIN     = xentrace xentrace_setsize
>  LIBBIN   = xenctx
>  SCRIPTS  = xentrace_format
>  MAN1     = $(wildcard *.1)
> @@ -16,15 +17,16 @@ MAN8     = $(wildcard *.8)
>  all: build
>  
>  .PHONY: build
> -build: $(BIN) $(LIBBIN)
> +build: $(BIN) $(SBIN) $(LIBBIN)
>  
>  .PHONY: install
>  install: build
>  	$(INSTALL_DIR) $(DESTDIR)$(bindir)
> +	$(INSTALL_DIR) $(DESTDIR)$(sbindir)
>  	[ -z "$(LIBBIN)" ] || $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
>  	$(INSTALL_DIR) $(DESTDIR)$(MAN1DIR)
>  	$(INSTALL_DIR) $(DESTDIR)$(MAN8DIR)
> -	$(INSTALL_PROG) $(BIN) $(DESTDIR)$(bindir)
> +	$(INSTALL_PROG) $(SBIN) $(DESTDIR)$(sbindir)
>  	$(INSTALL_PYTHON_PROG) $(SCRIPTS) $(DESTDIR)$(bindir)
>  	[ -z "$(LIBBIN)" ] || $(INSTALL_PROG) $(LIBBIN) $(DESTDIR)$(LIBEXEC_BIN)
>  	$(INSTALL_DATA) $(MAN1) $(DESTDIR)$(MAN1DIR)
> @@ -32,7 +34,7 @@ install: build
>  
>  .PHONY: clean
>  clean:
> -	$(RM) *.a *.so *.o *.rpm $(BIN) $(LIBBIN) $(DEPS)
> +	$(RM) *.a *.so *.o *.rpm $(BIN) $(SBIN) $(LIBBIN) $(DEPS)
>  
>  .PHONY: distclean
>  distclean: clean
>