From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yzq6F-00037x-24 for qemu-devel@nongnu.org; Tue, 02 Jun 2015 13:35:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yzq67-00027B-Fk for qemu-devel@nongnu.org; Tue, 02 Jun 2015 13:35:38 -0400 Received: from mail-qk0-x236.google.com ([2607:f8b0:400d:c09::236]:34387) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yzq67-00026x-BE for qemu-devel@nongnu.org; Tue, 02 Jun 2015 13:35:31 -0400 Received: by qkoo18 with SMTP id o18so105161344qko.1 for ; Tue, 02 Jun 2015 10:35:30 -0700 (PDT) Sender: Richard Henderson Message-ID: <556DE95E.8020600@twiddle.net> Date: Tue, 02 Jun 2015 10:35:26 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1433193897-24110-1-git-send-email-aurelien@aurel32.net> <1433193897-24110-13-git-send-email-aurelien@aurel32.net> In-Reply-To: <1433193897-24110-13-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 12/13] target-s390x: implement load-and-trap facility List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno , qemu-devel@nongnu.org Cc: Alexander Graf On 06/01/2015 02:24 PM, Aurelien Jarno wrote: > At the same time move the trap code from op_ct into gen_trap and use it > for all new functions. The value needs to be stored back to register > before the exception, but also before the brcond (as we don't use > temp locals). That's why we can't use wout helper. > > Cc: Alexander Graf > Cc: Richard Henderson > Signed-off-by: Aurelien Jarno > --- > target-s390x/insn-data.def | 10 ++++++ > target-s390x/translate.c | 80 ++++++++++++++++++++++++++++++++++++++++------ > 2 files changed, 81 insertions(+), 9 deletions(-) Reviewed-by: Richard Henderson r~