From: Richard Henderson <rth@twiddle.net>
To: Aurelien Jarno <aurelien@aurel32.net>, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Alexander Graf" <agraf@suse.de>,
"Yongbok Kim" <yongbok.kim@imgtec.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Leon Alrae" <leon.alrae@imgtec.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH RFC 3/5] softmmu: add a tlb_vaddr_to_host_fill function
Date: Tue, 02 Jun 2015 13:58:21 -0700 [thread overview]
Message-ID: <556E18ED.3070409@twiddle.net> (raw)
In-Reply-To: <20150602201032.GA5379@aurel32.net>
On 06/02/2015 01:10 PM, Aurelien Jarno wrote:
> It looks like we have to go through the MMIO functions to get the
> TLB_NOTDIRTY bit cleaned correctly. This is something we don't want for
> probe_write, so we definitely want two different functions.
I think that's why target-arm does it's somewhat convoluted loop in which it
stores one byte to the page and then tries again to use tlb_vaddr_to_host.
If the page isn't in the tlb, we perform a complete store and thus both pull
the page into the tlb as well as mark it dirty. Thus if the page still isn't
present for the second vaddr_to_host, it really is I/O, or is being watched by
the debugger, or something equally unlikely.
r~
next prev parent reply other threads:[~2015-06-02 20:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 11:26 [Qemu-devel] [PATCH RFC 0/5] softmmu and s390x memory helper improvements Aurelien Jarno
2015-06-02 11:26 ` [Qemu-devel] [PATCH RFC 1/5] target-s390x: add a cpu_mmu_idx_to_asc function Aurelien Jarno
2015-06-02 11:26 ` [Qemu-devel] [PATCH RFC 2/5] target-390x: support non current ASC in s390_cpu_handle_mmu_fault Aurelien Jarno
2015-06-02 11:26 ` [Qemu-devel] [PATCH RFC 3/5] softmmu: add a tlb_vaddr_to_host_fill function Aurelien Jarno
2015-06-02 20:10 ` Aurelien Jarno
2015-06-02 20:58 ` Richard Henderson [this message]
2015-06-02 21:11 ` Peter Maydell
2015-06-03 15:18 ` Aurelien Jarno
2015-06-02 20:54 ` Richard Henderson
2015-06-03 15:11 ` Aurelien Jarno
2015-06-02 11:26 ` [Qemu-devel] [PATCH RFC 4/5] target-s390x: function to adjust the length wrt page boundary Aurelien Jarno
2015-06-02 11:26 ` [Qemu-devel] [PATCH RFC 5/5] target-s390x: use softmmu host addr function for mvcp/mvcs Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556E18ED.3070409@twiddle.net \
--to=rth@twiddle.net \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=leon.alrae@imgtec.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=yongbok.kim@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.