Re: [Qemu-devel] [PULL 1/8] target-sh4: use bit number for SR constants

[Christopher Covington <cov@codeaurora.org>]

Hi Aurelien,

On 06/01/2015 05:29 PM, Aurelien Jarno wrote:
> Use the bit number for SR constants instead of using a bit mask. This
> make possible to also use the constants for shifts.
> 
> Reviewed-by: Richard Henderson <rth@twiddle.net>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
>  target-sh4/cpu.c       |  3 +-
>  target-sh4/cpu.h       | 30 ++++++++++----------
>  target-sh4/gdbstub.c   |  4 +--
>  target-sh4/helper.c    | 27 +++++++++---------
>  target-sh4/op_helper.c | 26 ++++++++---------
>  target-sh4/translate.c | 75 ++++++++++++++++++++++++++------------------------
>  6 files changed, 85 insertions(+), 80 deletions(-)
> 
> diff --git a/target-sh4/cpu.c b/target-sh4/cpu.c
> index d187a2b..cccb14f 100644
> --- a/target-sh4/cpu.c
> +++ b/target-sh4/cpu.c
> @@ -61,7 +61,8 @@ static void superh_cpu_reset(CPUState *s)
>      env->fpscr = FPSCR_PR; /* value for userspace according to the kernel */
>      set_float_rounding_mode(float_round_nearest_even, &env->fp_status); /* ?! */
>  #else
> -    env->sr = SR_MD | SR_RB | SR_BL | SR_I3 | SR_I2 | SR_I1 | SR_I0;
> +    env->sr = (1u << SR_MD) | (1u << SR_RB) | (1u << SR_BL) |
> +              (1u << SR_I3) | (1u << SR_I2) | (1u << SR_I1) | (1u << SR_I0);

I like using the BIT() macro for this kind of thing.

Chris

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project