From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH 12/15] KVM: MTRR: introduce mtrr_for_each_mem_type Date: Wed, 03 Jun 2015 10:57:30 +0800 Message-ID: <556E6D1A.7080709@linux.intel.com> References: <1432983566-15773-1-git-send-email-guangrong.xiao@linux.intel.com> <1432983566-15773-13-git-send-email-guangrong.xiao@linux.intel.com> <556C26D4.6030205@redhat.com> <556C6B87.6080403@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Paolo Bonzini Return-path: Received: from mga11.intel.com ([192.55.52.93]:59111 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751599AbbFCDB0 (ORCPT ); Tue, 2 Jun 2015 23:01:26 -0400 In-Reply-To: <556C6B87.6080403@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/01/2015 10:26 PM, Paolo Bonzini wrote: > > > On 01/06/2015 11:33, Paolo Bonzini wrote: >>> + looker->mem_type = looker->mtrr_state->fixed_ranges[index]; >>>> + looker->start = fixed_mtrr_range_end_addr(seg, index); >>>> + return true; >> in mtrr_lookup_fixed_start is the same as this: >> >>>> >>>> + end = fixed_mtrr_range_end_addr(looker->seg, looker->index); >>>> + >>>> + /* switch to next segment. */ >>>> + if (end >= eseg->end) { >>>> + looker->seg++; >>>> + looker->index = 0; >>>> + >>>> + /* have looked up for all fixed MTRRs. */ >>>> + if (looker->seg >= ARRAY_SIZE(fixed_seg_table)) >>>> + return mtrr_lookup_var_start(looker); >>>> + >>>> + end = fixed_mtrr_range_end_addr(looker->seg, looker->index); >>>> + } >>>> + >>>> + looker->mem_type = mtrr_state->fixed_ranges[looker->index]; >>>> + looker->start = end; >> in mtrr_lookup_fixed_next. Can you try to make them more common? >> >> Basically you should have >> >> +#define mtrr_for_each_mem_type(_looker_, _mtrr_, _gpa_start_, _gpa_end_) \ >> + for (mtrr_lookup_init(_looker_, _mtrr_, _gpa_start_, _gpa_end_); \ >> + !mtrr_lookup_end(_looker_); mtrr_lookup_next(_looker_)) > > ... where the above code I quoted would be part of mtrr_lookup_end. Okay, will do. :)