From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cn.fujitsu.com ([59.151.112.132]:12315 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752511AbbFCHR1 (ORCPT ); Wed, 3 Jun 2015 03:17:27 -0400 Message-ID: <556EA8E7.60701@cn.fujitsu.com> Date: Wed, 3 Jun 2015 15:12:39 +0800 From: Dongsheng Yang MIME-Version: 1.0 Subject: Re: [PATCH] xfstests: btrfs: 022: add a quota rescan -w to wait rescan finished. References: <1433315455-814-1-git-send-email-yangds.fnst@cn.fujitsu.com> In-Reply-To: <1433315455-814-1-git-send-email-yangds.fnst@cn.fujitsu.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: fstests-owner@vger.kernel.org To: fdmanana@gmail.com Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org List-ID: Hi Filip, Qu is off duty this week, would you please try this patch here? Thanx Yang On 06/03/2015 03:10 PM, Dongsheng Yang wrote: > When we enable quota, btrfs will rescan quota numbers. We need > to wait the rescan finished before any more operations on btrfs > qgroups. Otherwith, the new btrfs-progs would WARN out: > > WARNING: Rescan is running, qgroup data may be incorrect. > > It would make btrfs/022 failed. > > Signed-off-by: Dongsheng Yang > --- > tests/btrfs/022 | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/btrfs/022 b/tests/btrfs/022 > index 5c1a82d..56d4f3d 100755 > --- a/tests/btrfs/022 > +++ b/tests/btrfs/022 > @@ -51,6 +51,7 @@ _basic_test() > { > _run_btrfs_util_prog subvolume create $SCRATCH_MNT/a > _run_btrfs_util_prog quota enable $SCRATCH_MNT/a > + _run_btrfs_util_prog quota rescan -w $SCRATCH_MNT > subvolid=$(_btrfs_get_subvolid $SCRATCH_MNT a) > $BTRFS_UTIL_PROG qgroup show $units $SCRATCH_MNT | grep $subvolid >> \ > $seqres.full 2>&1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cn.fujitsu.com ([59.151.112.132]:12315 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752511AbbFCHR1 (ORCPT ); Wed, 3 Jun 2015 03:17:27 -0400 Message-ID: <556EA8E7.60701@cn.fujitsu.com> Date: Wed, 3 Jun 2015 15:12:39 +0800 From: Dongsheng Yang MIME-Version: 1.0 To: CC: , Subject: Re: [PATCH] xfstests: btrfs: 022: add a quota rescan -w to wait rescan finished. References: <1433315455-814-1-git-send-email-yangds.fnst@cn.fujitsu.com> In-Reply-To: <1433315455-814-1-git-send-email-yangds.fnst@cn.fujitsu.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Sender: linux-btrfs-owner@vger.kernel.org List-ID: Hi Filip, Qu is off duty this week, would you please try this patch here? Thanx Yang On 06/03/2015 03:10 PM, Dongsheng Yang wrote: > When we enable quota, btrfs will rescan quota numbers. We need > to wait the rescan finished before any more operations on btrfs > qgroups. Otherwith, the new btrfs-progs would WARN out: > > WARNING: Rescan is running, qgroup data may be incorrect. > > It would make btrfs/022 failed. > > Signed-off-by: Dongsheng Yang > --- > tests/btrfs/022 | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/btrfs/022 b/tests/btrfs/022 > index 5c1a82d..56d4f3d 100755 > --- a/tests/btrfs/022 > +++ b/tests/btrfs/022 > @@ -51,6 +51,7 @@ _basic_test() > { > _run_btrfs_util_prog subvolume create $SCRATCH_MNT/a > _run_btrfs_util_prog quota enable $SCRATCH_MNT/a > + _run_btrfs_util_prog quota rescan -w $SCRATCH_MNT > subvolid=$(_btrfs_get_subvolid $SCRATCH_MNT a) > $BTRFS_UTIL_PROG qgroup show $units $SCRATCH_MNT | grep $subvolid >> \ > $seqres.full 2>&1 >