From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37090) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z045b-0001NA-Gg for qemu-devel@nongnu.org; Wed, 03 Jun 2015 04:31:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z045Z-00045z-JK for qemu-devel@nongnu.org; Wed, 03 Jun 2015 04:31:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34119) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z045Z-00044n-DM for qemu-devel@nongnu.org; Wed, 03 Jun 2015 04:31:53 -0400 Message-ID: <556EBB73.70901@redhat.com> Date: Wed, 03 Jun 2015 10:31:47 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20150601141054.GA11304@redhat.com> <20150601141343.GH13155@redhat.com> <20150601153237.GE2120@HEDWIG.INI.CMU.EDU> <20150601174409-mutt-send-email-mst@redhat.com> <20150601180022.GI2120@HEDWIG.INI.CMU.EDU> <20150601203126.GK2120@HEDWIG.INI.CMU.EDU> <1433229074.1637.7.camel@nilsson.home.kraxel.org> In-Reply-To: <1433229074.1637.7.camel@nilsson.home.kraxel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] fw cfg files cross-version migration races List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , "Gabriel L. Somlo" Cc: lersek@redhat.com, "Gabriel L. Somlo" , qemu-devel@nongnu.org, "Michael S. Tsirkin" On 02/06/2015 09:11, Gerd Hoffmann wrote: > Accessing fw_cfg after migration is fine. Problem is this ... > > (1) read directory > (2) migrate > (3) read file > > ... in case the file ordering happens to be different on the destination > host due to initialization order changes. > > So, sorting entries (and the index assigned too) should fix this, right? > That looks easiest to me. Agreed. Paolo