From: Alexander Popov <alpopov@ptsecurity.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Andrey Ryabinin <a.ryabinin@samsung.com>,
Andrey Konovalov <adech.fo@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Andy Lutomirski <luto@amacapital.net>,
Alexander Kuleshov <kuleshovmail@gmail.com>,
"Borislav Petkov" <bp@suse.de>,
Denys Vlasenko <dvlasenk@redhat.com>, <x86@kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/1] x86_64: fix KASan shadow region page tables
Date: Wed, 3 Jun 2015 11:37:23 +0300 [thread overview]
Message-ID: <556EBCC3.4070500@ptsecurity.com> (raw)
In-Reply-To: <20150603074427.GA1598@gmail.com>
On 03.06.2015 10:44, Ingo Molnar wrote:
>
> * Alexander Popov <alpopov@ptsecurity.com> wrote:
>> + kasan_early_init();
>> + kasan_map_early_shadow(early_level4_pgt);
>
> So why isn't kasan_map_early_shadow() called in kasan_early_init()?
>
> High level x86 init code should not be polluted with too many low level details.
Hello, Ingo.
kasan_map_early_shadow() is called twice in x86_64_start_kernel():
once for early_level4_pgt and then later for init_level4_pgt.
I've decided to introduce separate kasan_early_init() to avoid big changes
which can bring consequences that I don't understand.
Best regards,
Alexander
next prev parent reply other threads:[~2015-06-03 8:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 12:57 [PATCH v4 1/1] x86_64: fix KASan shadow region page tables Alexander Popov
2015-06-03 7:44 ` Ingo Molnar
2015-06-03 8:37 ` Alexander Popov [this message]
2015-06-03 8:44 ` Andrey Ryabinin
2015-06-03 14:10 ` Alexander Popov
2015-06-03 16:33 ` Andrey Ryabinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556EBCC3.4070500@ptsecurity.com \
--to=alpopov@ptsecurity.com \
--cc=a.ryabinin@samsung.com \
--cc=adech.fo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bp@suse.de \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.