Re: RFC: making the PVH 64bit ABI as stableo

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 03/06/15 10:00, Ian Campbell wrote:
> On Tue, 2015-06-02 at 18:09 +0100, Andrew Cooper wrote:
>> * Removal of all /* TODO pvhfixme */ from the code
> I guess this is not the literal tag:
> ianc@cosworth:xen.git$ git grep -i TODO.pvhfixme xen
> ianc@cosworth:xen.git$ git grep -i TODO.*pvh xen
> ianc@cosworth:xen.git$
>
> I think you meant:
> ianc@cosworth:xen.git$ git grep -i pvh.fixme xen
> xen/arch/x86/domain_build.c: * pvh fixme: The following doesn't map MMIO ranges when they sit above the
> xen/arch/x86/domain_build.c:     * PVH Fixme: XENFEAT_supervisor_mode_kernel has been reused in PVH with a
> xen/arch/x86/hvm/vmx/vmx.c:            if ( unlikely(is_pvh_vcpu(v)) /* PVH fixme */ ||
> xen/arch/x86/mm/p2m-pt.c:        /* pvh fixme: foreign types are only supported on ept at present */
> xen/arch/x86/mm/p2m.c: * pvh fixme: when adding support for pvh non-hardware domains, this path must
> xen/arch/x86/mm/p2m.c:     * pvh fixme: until support is added to p2m teardown code to cleanup any
> xen/arch/x86/time.c:         * PVH fixme: support more tsc modes.
> xen/arch/x86/traps.c:    if ( !d || !d->vcpu || !d->vcpu[0] || !is_pv_domain(d) /* PVH fixme */ )
> xen/common/vm_event.c:            /* pvh fixme: p2m_is_foreign types need addressing */
> xen/common/vm_event.c:            /* pvh fixme: p2m_is_foreign types need addressing */
>
> Are there other variants or is this the list?
>
>

At least one more comes to mind.

andrewcoop@andrewcoop:/local/xen.git/xen$ git grep -i "PVH 32bitfixme"
arch/x86/domain.c:768:        /* PVH 32bitfixme */
arch/x86/hvm/hvm.c:2318:        v->arch.hvm_vcpu.hcall_64bit = 1;    /*
PVH 32bitfixme. */
arch/x86/hvm/hvm.c:4898:/* PVH 32bitfixme. */
arch/x86/hvm/hvm.c:5003:        regs->_eax = -ENOSYS; /* PVH 32bitfixme. */
arch/x86/hvm/vmx/vmcs.c:987:        /* Start in 64-bit mode. PVH
32bitfixme. */
arch/x86/hvm/vmx/vmcs.c:1128:        /* CS.L == 1, exec, read/write,
accessed. PVH 32bitfixme. */

~Andrew