From: Jason Wang <jasowang@redhat.com>
To: Thibaut Collet <thibaut.collet@6wind.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
Giuseppe Lettieri <g.lettieri@iet.unipi.it>,
Luigi Rizzo <rizzo@iet.unipi.it>,
qemu-devel@nongnu.org, Vincenzo Maffione <v.maffione@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] net: fix queue's purge on VM stop
Date: Wed, 03 Jun 2015 17:42:09 +0800 [thread overview]
Message-ID: <556ECBF1.8020702@redhat.com> (raw)
In-Reply-To: <CABUUfwNfeuSQKDX-maAfOJMMJwZjHWbTWj9Dzr3X9Y4UtCXD1Q@mail.gmail.com>
On 06/03/2015 03:56 PM, Thibaut Collet wrote:
> Hi,
>
> thanks for your point, I did not notice the problem of the lost of ARP
> announce by discarding the message.
> So I must rewrite my patch to define a queue to transmit the ARP
> announce to the guest. Is it the proper solution?
>
Please have a look at VIRTIO_NET_F_GUEST_ANNOUNCE. It can notify guest
after migration to let it to send arp announce. Recent linux driver has
this support.
> Thanks.
>
> Best regards.
>
> Thibaut.
>
> On Tue, Jun 2, 2015 at 12:34 PM, Stefan Hajnoczi <stefanha@redhat.com
> <mailto:stefanha@redhat.com>> wrote:
>
> On Fri, May 29, 2015 at 04:28:48PM +0200, Thibaut Collet wrote:
> > I agree that virtio-net NIC never enqueues packet to vhost-user
> > but qemu_announce_self function (savevm.c file) can do it through
> > the qemu_announce_self_iter / qemu_send_packet_raw sequence.
>
> Does vhost-user support live migration?
>
> If no, then qemu_announce_self is never called.
>
> If yes, then the packet should not be discarded since the ARP announce
> has a purpose.
>
> Stefan
>
>
next prev parent reply other threads:[~2015-06-03 9:42 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 8:03 [Qemu-devel] [PATCH 1/1] net: fix queue's purge on VM stop Thibaut Collet
2015-05-29 13:12 ` Stefan Hajnoczi
2015-05-29 14:28 ` Thibaut Collet
2015-06-02 10:34 ` Stefan Hajnoczi
2015-06-03 7:56 ` Thibaut Collet
2015-06-03 9:42 ` Jason Wang [this message]
2015-06-03 13:40 ` Stefan Hajnoczi
2015-06-04 9:35 ` Jason Wang
2015-06-05 13:24 ` [Qemu-devel] [PATCH v2] net: Add support of VIRTIO_NET_F_GUEST_ANNOUNCE for vhost-net/vhost-user Thibaut Collet
2015-06-08 5:55 ` Jason Wang
2015-06-08 8:21 ` Thibaut Collet
2015-06-08 9:14 ` Jason Wang
2015-06-08 10:01 ` Thibaut Collet
2015-06-08 10:09 ` Michael S. Tsirkin
2015-06-08 10:22 ` Jason Wang
2015-06-08 13:32 ` Stefan Hajnoczi
2015-06-08 14:05 ` Thibaut Collet
2015-06-08 15:13 ` Stefan Hajnoczi
2015-06-08 15:32 ` Thibaut Collet
2015-06-09 10:38 ` Stefan Hajnoczi
2015-06-09 10:43 ` Stefan Hajnoczi
2015-06-08 16:13 ` Michael S. Tsirkin
2015-06-09 2:35 ` Jason Wang
2015-06-08 10:12 ` Michael S. Tsirkin
2015-06-08 11:29 ` Thibaut Collet
2015-06-08 12:45 ` Michael S. Tsirkin
2015-06-08 13:20 ` Thibaut Collet
2015-06-08 15:48 ` Michael S. Tsirkin
2015-06-08 13:25 ` Stefan Hajnoczi
2015-06-03 9:42 ` [Qemu-devel] [PATCH 1/1] net: fix queue's purge on VM stop Stefan Hajnoczi
2015-06-01 9:17 ` Jason Wang
2015-06-01 10:14 ` Thibaut Collet
2015-06-03 9:40 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556ECBF1.8020702@redhat.com \
--to=jasowang@redhat.com \
--cc=g.lettieri@iet.unipi.it \
--cc=qemu-devel@nongnu.org \
--cc=rizzo@iet.unipi.it \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
--cc=thibaut.collet@6wind.com \
--cc=v.maffione@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.