Re: [PATCH 2/2] ARM: DRA7: hwmod: Fix GPMC from preventing core suspend

[Roger Quadros <rogerq@ti.com>]

Paul,

On 03/06/15 00:36, Paul Walmsley wrote:
> On Tue, 2 Jun 2015, Roger Quadros wrote:
>
>> GPMC hwmod is flagged as HWMOD_INIT_NO_IDLE so it is kept
>> enabled at boot. If the GPMC driver is not loaded then
>> GPMC will not be idled thus preventing CORE from going idle
>> during suspend.
>>
>> Disable HWMOD_INIT_NO_IDLE and HWMOD_INIT_NO_RESET.
>>
>> The only reason HWMOD_INIT_NO_RESET was there was to retain
>> GPMC timings/settings configured by bootloader. We no longer
>> need that as we're configuring the timins in the kernel.
>>
>> There is no reasoning as to why HWMOD_INIT_NO_IDLE was there.
>> Seems to have beein blindly copied from omap3/4 hwmod code.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>
> Hi Roger, could you take a look at Tony's patch "memory: omap-gpmc: Add
> Kconfig option for debug" and see if this needs to be changed in light of
> that patch?

Yes. We don't need this patch if we can just rid of HWMOD_SWSUP_SIDLE
as done in the first patch.

cheers,
-roger