Re: [PATCH] libmultipath: don't lock block device but use lock files

[Hannes Reinecke <hare@suse.de>]

On 06/02/2015 02:09 PM, Christian Seiler wrote:
> Am 2015-05-24 10:05, schrieb Christian Seiler:
>> That said, I've noticed that my patch might cause multipathd to have
>> the lock file fds open unnecessarily, so I've updated it to close them
>> on regular unlocking (but not on failure, because that means there will
>> be a retry). Version 2 is attached.
> 
> Ping?
> 
Probably I'm showing my ignorance here, but do we _really_ need this?
Is this really an issue? Personally I've never had any issue with
locking multipathd against multipath; plus I'm not aware of any scenario
which uses 'multipath' on a regular basis.
All scripts I know of rely on multipathd to maintain the path states,
and 'multipath' is only ever used to query the state of the devices.
Using 'multipath' to maintain the paths themselves are typically used
only manually, so any failure can easily be overcome.

Do you have an example where this patch is required?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)