From: Michael Wood <michael.g.wood@intel.com>
To: "Damian, Alexandru" <alexandru.damian@intel.com>,
"toaster@yoctoproject.org" <toaster@yoctoproject.org>
Subject: Re: [review-request] adamian/20150515_fix_table_header - REST refactoring
Date: Wed, 03 Jun 2015 14:59:49 +0100 [thread overview]
Message-ID: <556F0855.2060008@intel.com> (raw)
In-Reply-To: <CAJ2CSBt2fUzPpfgx4E55eeBRnVmi=g+C=iuvmnm6ghK6Ku5C4w@mail.gmail.com>
8305ee985bdc87dcfb63be4e0ddafb0a9239ffd4
Looks good to me.
Yeah that's a good idea to make ToasterTable inherit from TemplateView
rather than have it in between.
Thanks,
Michael
On 03/06/15 14:15, Damian, Alexandru wrote:
> Hi,
>
> I've progressed a bit with the REST refactoring, I've tackled the
> ToasterTables. Thanks to good quality of the existing code , changing
> the layout of the URL was straightforward.
>
> adamian/20150515_fix_table_header
>
> This reduces the number of entry points for the URL, removes the ugly
> hardcoding of XHR_ table urls in tables.py, and makes sure the APIs
> are both human- and machine-readable.
>
> I'll continue with refactoring to remove the xhr_datatypeahead and
> similar URL endpoints which should not have existed in the first place.
>
> Cheers,
> Alex
>
> --
> Alex Damian
> Yocto Project
> SSG / OTC
>
>
next prev parent reply other threads:[~2015-06-03 14:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 13:15 [review-request] adamian/20150515_fix_table_header - REST refactoring Damian, Alexandru
2015-06-03 13:59 ` Michael Wood [this message]
2015-06-03 14:35 ` Damian, Alexandru
2015-06-04 9:25 ` Barros Pena, Belen
2015-06-08 17:43 ` Damian, Alexandru
2015-06-08 17:44 ` Damian, Alexandru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556F0855.2060008@intel.com \
--to=michael.g.wood@intel.com \
--cc=alexandru.damian@intel.com \
--cc=toaster@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.