From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 2C584E00A1C; Wed, 3 Jun 2015 07:00:11 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, TRACKER_ID autolearn=no version=3.3.1 X-Spam-HAM-Report: * 1.3 TRACKER_ID BODY: Incorporates a tracking ID number * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.212.181 listed in list.dnswl.org] Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 55F2BE009EA for ; Wed, 3 Jun 2015 06:59:50 -0700 (PDT) Received: by wifw1 with SMTP id w1so23247364wif.0 for ; Wed, 03 Jun 2015 06:59:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=buIHmqAsD67kA17crZA3ybI+KV69ypgxnbn1+hrX7w4=; b=AFkcy8reS1ASfHfNvS4izAq+YLhfVCzoNbcChOvBZauu/FEKemk8bzv9AtCFkV4x4I t1VJKbfYwrQ7vQnVE43gG9kgi274dNlsP8dOuSX/hMimU4Prmv2roM8+h1CbABS/wp20 SdEhCXTE28Jqzyu9Rr7OJjHjfivrKCNH/lf6wG56Bga/DVxWcoBBr9+YpyuHy6uikghT jVbn6afYep3ob5d8mUOXRHEYmtnbVQ5UliRVVnCmpWJ1ylI7kO+OlZ1QDThVe0iC0pRS Clrt2rTQtiixXaGEB12OQn99tNRQHHa/fFI2EFszZTckLIdOiKtX3CQeMlOUM3kbKWLh laqA== X-Gm-Message-State: ALoCoQldtWSNXu2jFa0kgW2yleYAN9XJI2BD3LK9Dmq+Wi0GVbsM8GgsGY43wN0fOu9TkscK8Bgb X-Received: by 10.180.187.232 with SMTP id fv8mr42842593wic.28.1433339990166; Wed, 03 Jun 2015 06:59:50 -0700 (PDT) Received: from [192.168.2.168] ([83.217.123.106]) by mx.google.com with ESMTPSA id w11sm1216421wjr.48.2015.06.03.06.59.49 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Jun 2015 06:59:49 -0700 (PDT) Message-ID: <556F0855.2060008@intel.com> Date: Wed, 03 Jun 2015 14:59:49 +0100 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Damian, Alexandru" , "toaster@yoctoproject.org" References: In-Reply-To: Subject: Re: [review-request] adamian/20150515_fix_table_header - REST refactoring X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jun 2015 14:00:11 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit 8305ee985bdc87dcfb63be4e0ddafb0a9239ffd4 Looks good to me. Yeah that's a good idea to make ToasterTable inherit from TemplateView rather than have it in between. Thanks, Michael On 03/06/15 14:15, Damian, Alexandru wrote: > Hi, > > I've progressed a bit with the REST refactoring, I've tackled the > ToasterTables. Thanks to good quality of the existing code , changing > the layout of the URL was straightforward. > > adamian/20150515_fix_table_header > > This reduces the number of entry points for the URL, removes the ugly > hardcoding of XHR_ table urls in tables.py, and makes sure the APIs > are both human- and machine-readable. > > I'll continue with refactoring to remove the xhr_datatypeahead and > similar URL endpoints which should not have existed in the first place. > > Cheers, > Alex > > -- > Alex Damian > Yocto Project > SSG / OTC > >