All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shirley Ma <shirley.ma@oracle.com>
To: "'Tom Tucker'" <tom@opengridcomputing.com>,
	Chuck Lever <Chuck.Lever@oracle.com>,
	Steve Wise <swise@opengridcomputing.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: [PATCH RFC] NFS/RDMA Release resources in svcrdma when device is removed
Date: Wed, 03 Jun 2015 11:40:12 -0700	[thread overview]
Message-ID: <556F4A0C.2030804@oracle.com> (raw)

When removing underlying RDMA device, the rmmod will hang forever if there
are any outstanding NFS/RDMA client mounts. The outstanding NFS/RDMA counts 
could also prevent the server from shutting down. Further debugging shows 
that the existing connections are not teared down and resource are not 
released when receiving RDMA_CM_EVENT_DEVICE_REMOVAL event. It seems the 
original code missing svc_xprt_put() in RDMA_CM_EVENT_REMOVAL event handler 
thus svc_xprt_free is never invoked to release the existing connection resources.

The patch has been passed removing, adding device back and forth without 
stopping NFS/RDMA service. This will also allow a device to be unplugged 
and swapped out without shutting down NFS service.

Signed-off-by: Shirley Ma <shirley.ma@oracle.com>
---
 net/sunrpc/xprtrdma/svc_rdma_transport.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c
index f609c1c..2b82569 100644
--- a/net/sunrpc/xprtrdma/svc_rdma_transport.c
+++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c
@@ -673,6 +673,7 @@ static int rdma_cma_handler(struct rdma_cm_id *cma_id,
 		if (xprt) {
 			set_bit(XPT_CLOSE, &xprt->xpt_flags);
 			svc_xprt_enqueue(xprt);
+			svc_xprt_put(xprt);
 		}
 		break;
 	default:

Shirley

             reply	other threads:[~2015-06-03 18:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03 18:40 Shirley Ma [this message]
2015-06-03 18:44 ` [PATCH RFC] NFS/RDMA Release resources in svcrdma when device is removed Chuck Lever
2015-06-03 18:49   ` Chuck Lever
2015-06-03 21:56     ` Shirley Ma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=556F4A0C.2030804@oracle.com \
    --to=shirley.ma@oracle.com \
    --cc=Chuck.Lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=swise@opengridcomputing.com \
    --cc=tom@opengridcomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.