From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932345AbbFCS5Z (ORCPT ); Wed, 3 Jun 2015 14:57:25 -0400 Received: from terminus.zytor.com ([198.137.202.10]:37019 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758588AbbFCS5R (ORCPT ); Wed, 3 Jun 2015 14:57:17 -0400 Message-ID: <556F4DE1.8070706@zytor.com> Date: Wed, 03 Jun 2015 11:56:33 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Borislav Petkov , LKML CC: Andrew Morton , Andy Lutomirski , Ingo Molnar , "Peter Zijlstra (Intel)" , Thomas Gleixner , x86@kernel.org, David Howells , Len Brown Subject: Re: [PATCH] x86/asm/msr: Retract msr-index.h References: <1433335308-27114-1-git-send-email-bp@alien8.de> <20150603182134.GR4403@pd.tnic> In-Reply-To: <20150603182134.GR4403@pd.tnic> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/03/2015 11:21 AM, Borislav Petkov wrote: > On Wed, Jun 03, 2015 at 02:41:48PM +0200, Borislav Petkov wrote: >> This header containing all MSRs and respective bit definitions got >> exported to userspace in conjunction with the big uapi shuffle. >> >> But, it doesn't have anything to do in the uapi headers because >> userspace can do its own MSR defines and exporting them from the >> kernel blocks us from doing cleanups/renames in that header. Which is >> ridiculous - it is not kernel's job to export such a header and keep >> MSRs list and their names stable. > > Here's v2. Needed to *not* include it into uapi/asm/msr.h either. I really like the patch, but the description is awful. How about: "x86/uapi: is not a UAPI" -hpa