Re: [Devel] [RFC] proposed patch for some segfaults encountered

[Al Stone <ahs3 at redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1610 bytes --]

Awesome.  Thanks.

On 06/03/2015 03:06 PM, Moore, Robert wrote:
> Anyway, I added a check for a null target in AcpiDmIsValidTarget, and for the StoreOp target case. That should at least cover all of these types of cases.
> 
> 
>> -----Original Message-----
>> From: Devel [mailto:devel-bounces(a)acpica.org] On Behalf Of Al Stone
>> Sent: Monday, June 01, 2015 1:59 PM
>> To: devel(a)acpica.org
>> Subject: [Devel] [RFC] proposed patch for some segfaults encountered
>>
>> It's not clear to me that this is the correct way to handle a segfault
>> that was reported to me via Fedora.
>>
>> Using the ssdt9.dat file attached, a simple "iasl -d ssdt9.dat" will
>> segfault around calls to AcpiDmPromoteTarget -- and it turns out that the
>> Target pointer being passed into that function was sometimes null but not
>> being checked in the calling function, AcpiDmCheckForSymbolicOpcode.  So,
>> this patch adds in some checks for null pointers and can now get through
>> this particular problem.
>>
>> However, I did not study AcpiDmCheckForSymbolicOpcode long enough to
>> determine if the Target pointer in that function should or should not ever
>> be null.  So, this patch fixes this issue, but it may not be the proper
>> long term solution.
>>
>> --
>> ciao,
>> al
>> -----------------------------------
>> Al Stone
>> Software Engineer
>> Red Hat, Inc.
>> ahs3(a)redhat.com
>> -----------------------------------


-- 
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Red Hat, Inc.
ahs3(a)redhat.com
-----------------------------------