From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0GQP-0004aO-9n for qemu-devel@nongnu.org; Wed, 03 Jun 2015 17:42:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0GQL-0002IV-9i for qemu-devel@nongnu.org; Wed, 03 Jun 2015 17:42:13 -0400 Received: from mail-pa0-x232.google.com ([2607:f8b0:400e:c03::232]:32942) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0GQL-0002IK-20 for qemu-devel@nongnu.org; Wed, 03 Jun 2015 17:42:09 -0400 Received: by padj3 with SMTP id j3so15287053pad.0 for ; Wed, 03 Jun 2015 14:42:08 -0700 (PDT) Sender: Richard Henderson Message-ID: <556F74AC.3080108@twiddle.net> Date: Wed, 03 Jun 2015 14:42:04 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1433365796-1118-1-git-send-email-aurelien@aurel32.net> <1433365796-1118-15-git-send-email-aurelien@aurel32.net> In-Reply-To: <1433365796-1118-15-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 14/16] target-s390x: support non current ASC in s390_cpu_handle_mmu_fault List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno , qemu-devel@nongnu.org Cc: Alexander Graf On 06/03/2015 02:09 PM, Aurelien Jarno wrote: > s390_cpu_handle_mmu_fault currently looks at the current ASC mode > defined in PSW mask instead of the MMU index. This prevent emulating > easily instructions using a specific ASC mode. Fix that by using the > MMU index converted back to ASC using the just added cpu_mmu_idx_to_asc > function. > > Cc: Alexander Graf > Cc: Richard Henderson > Signed-off-by: Aurelien Jarno > --- > target-s390x/helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~