All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
	Bharata B Rao <bharata@linux.vnet.ibm.com>
Cc: zhugh.fnst@cn.fujitsu.com,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Alexander Graf" <agraf@suse.de>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH v3 0/3] Bitmap based CPU enumeration
Date: Thu, 04 Jun 2015 10:09:04 +0200	[thread overview]
Message-ID: <557007A0.9010204@redhat.com> (raw)
In-Reply-To: <CAEgOgz5hfLpSYkfBgChegH5uypYvNGwjV6tS8mw4K3Qk01m7=A@mail.gmail.com>

On 04/06/2015 07:44, Peter Crosthwaite wrote:
> On Wed, Jun 3, 2015 at 8:08 PM, Bharata B Rao
> <bharata@linux.vnet.ibm.com> wrote:
>> On Thu, May 28, 2015 at 09:59:38PM -0700, Peter Crosthwaite wrote:
>>> On Thu, May 28, 2015 at 7:27 PM, Bharata B Rao
>>> <bharata@linux.vnet.ibm.com> wrote:
>>>> All the comments have been addressed and the series has been reviewed
>>>> by David, Eduardo and Igor. Can this series be taken in now ?
>>>>
>>>
>>> Andreas' comment on P3 looks unaddressed. I think it can be handled by
>>> just putting that one sentance explanation you gave in commit message,
>>> or if its far enough out of scope just drop the change.
>>>
>>> I think Igor's comment was an out of scope suggestion in the end so
>>> nothing needed there?
>>>
>>> Regards,
>>> Peter
>>>
>>> P.S. I am not the maintainer but I need to rebase on you for one of my
>>> patch sets so I'd like to help see this though!
>>
>> Should I be rebasing against latest master or anyone else's tree to make
>> it easier for inclusion ?
>>
> 
> I don't know about anyone elses tree, but there is an edit to last
> patch so a fresh complete v4 rebased is probably going to make life
> easy for whoever.
> 
> I have CCd Paolo who owns exec.c according to MAINTAINERS.

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

I wouldn't mind separating the "CPU" parts of exec.c and moving them
under Andreas and Eduardo's mantainership.  In fact, Peter, in your
patch to move stuff from cpu-exec.c to cpus.c, perhaps you can use
qom/cpu.c instead?  Then qom/cpu.c can also be the place where we can
move the CPU parts of exec.c.

Paolo

  reply	other threads:[~2015-06-04  8:09 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-21  5:02 [Qemu-devel] [PATCH v3 0/3] Bitmap based CPU enumeration Bharata B Rao
2015-05-21  5:02 ` [Qemu-devel] [PATCH v3 1/3] cpus: Add Error argument to cpu_exec_init() Bharata B Rao
2015-05-21  8:50   ` Igor Mammedov
2015-05-25  1:03   ` David Gibson
2015-05-29  5:02   ` Peter Crosthwaite
2015-05-21  5:02 ` [Qemu-devel] [PATCH v3 2/3] cpus: Convert cpu_index into a bitmap Bharata B Rao
2015-05-21  8:58   ` Igor Mammedov
2015-05-25  1:05   ` David Gibson
2015-05-29  5:15   ` Peter Crosthwaite
2015-05-21  5:02 ` [Qemu-devel] [PATCH v3 3/3] ppc: Move cpu_exec_init() call to realize function Bharata B Rao
2015-05-21  5:28   ` Andreas Färber
2015-05-21  5:37     ` Bharata B Rao
2015-05-21  9:05   ` Igor Mammedov
2015-05-21 10:18     ` Bharata B Rao
2015-05-21 11:24       ` Igor Mammedov
2015-05-29  5:17   ` Peter Crosthwaite
2015-05-29  7:33     ` Bharata B Rao
2015-05-29  2:27 ` [Qemu-devel] [PATCH v3 0/3] Bitmap based CPU enumeration Bharata B Rao
2015-05-29  4:59   ` Peter Crosthwaite
2015-06-04  3:08     ` Bharata B Rao
2015-06-04  5:44       ` Peter Crosthwaite
2015-06-04  8:09         ` Paolo Bonzini [this message]
2015-06-04  8:39           ` Peter Crosthwaite
2015-06-04  8:51             ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=557007A0.9010204@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=bharata@linux.vnet.ibm.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zhugh.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.