From: Yang Hongyang <yanghy@cn.fujitsu.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: wei.liu2@citrix.com, wency@cn.fujitsu.com,
Andrew Cooper <andrew.cooper3@citrix.com>,
yunhong.jiang@intel.com, eddie.dong@intel.com,
xen-devel@lists.xen.org, guijianfeng@cn.fujitsu.com,
rshriram@cs.ubc.ca, ian.jackson@eu.citrix.com
Subject: Re: [PATCH v1 COLO Pre 03/12] tools/libxc: export xc_bitops.h
Date: Thu, 4 Jun 2015 16:51:14 +0800 [thread overview]
Message-ID: <55701182.2040409@cn.fujitsu.com> (raw)
In-Reply-To: <1433406998.7108.86.camel@citrix.com>
On 06/04/2015 04:36 PM, Ian Campbell wrote:
> On Thu, 2015-06-04 at 09:01 +0800, Yang Hongyang wrote:
>>
>> On 06/02/2015 06:11 PM, Andrew Cooper wrote:
>>> On 02/06/15 10:26, Yang Hongyang wrote:
>>>> When we are under COLO, we will send dirty page bitmap info from
>>>> secondary to primary at every checkpoint. So we need to get/test
>>>> the dirty page bitmap. We just expose xc_bitops.h for libxl use.
>>>>
>>>> NOTE:
>>>> Need to make clean and rerun configure to get it compiled.
>>>>
>>>> Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>
>>>
>>> I like this change, but lets take the opportunity to fix some of the
>>> issues in it.
>>
>> Thanks, will fix in next version.
>
> Please do fix and move in two separate patches, probably fix first
> although I don't mind overall.
Sure, will do.
>
> Ian.
>
> .
>
--
Thanks,
Yang.
next prev parent reply other threads:[~2015-06-04 8:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 9:26 [PATCH v1 COLO Pre 00/12] Prerequisite patches for COLO Yang Hongyang
2015-06-02 9:26 ` [PATCH v1 COLO Pre 01/12] tools/libxc: support to resume uncooperative HVM guests Yang Hongyang
2015-06-02 9:26 ` [PATCH v1 COLO Pre 02/12] libxc/restore: zero ioreq page only one time Yang Hongyang
2015-06-02 10:16 ` Andrew Cooper
2015-06-02 10:25 ` Wen Congyang
2015-06-02 9:26 ` [PATCH v1 COLO Pre 03/12] tools/libxc: export xc_bitops.h Yang Hongyang
2015-06-02 10:11 ` Andrew Cooper
2015-06-04 1:01 ` Yang Hongyang
2015-06-04 8:36 ` Ian Campbell
2015-06-04 8:51 ` Yang Hongyang [this message]
2015-06-02 9:26 ` [PATCH v1 COLO Pre 04/12] tools/libxl: introduce a new API libxl__domain_restore() to load qemu state Yang Hongyang
2015-06-02 9:38 ` Wen Congyang
2015-06-02 9:49 ` Yang Hongyang
2015-06-02 9:26 ` [PATCH v1 COLO Pre 05/12] tools/libxl: Introduce a new internal API libxl__domain_unpause() Yang Hongyang
2015-06-02 9:26 ` [PATCH v1 COLO Pre 06/12] tools/libxl: Update libxl__domain_unpause() to support qemu-xen Yang Hongyang
2015-06-02 9:26 ` [PATCH v1 COLO Pre 07/12] tools/libxl: introduce libxl__domain_common_switch_qemu_logdirty() Yang Hongyang
2015-06-02 9:26 ` [PATCH v1 COLO Pre 08/12] tools/libxl: Update libxl_save_msgs_gen.pl to support return data from xl to xc Yang Hongyang
2015-06-02 9:26 ` [PATCH v1 COLO Pre 09/12] tools/libxl: Add back channel to allow migration target send data back Yang Hongyang
2015-06-02 9:26 ` [PATCH v1 COLO Pre 10/12] tools/libxl: rename remus device to checkpoint device Yang Hongyang
2015-06-02 9:26 ` [PATCH v1 COLO Pre 11/12] tools/libxl: adjust the indentation Yang Hongyang
2015-06-02 9:26 ` [PATCH v1 COLO Pre 12/12] tools/libxl: don't touch remus in checkpoint_device Yang Hongyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55701182.2040409@cn.fujitsu.com \
--to=yanghy@cn.fujitsu.com \
--cc=andrew.cooper3@citrix.com \
--cc=eddie.dong@intel.com \
--cc=guijianfeng@cn.fujitsu.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=rshriram@cs.ubc.ca \
--cc=wei.liu2@citrix.com \
--cc=wency@cn.fujitsu.com \
--cc=xen-devel@lists.xen.org \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.