All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>, Wei Liu <wei.liu2@citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Don Slutz <dslutz@verizon.com>,
	andrew@zion.uk.xensource.com,
	xen-devel <xen-devel@lists.xenproject.org>,
	Yang Hongyang <yanghy@cn.fujitsu.com>
Subject: Re: RFC: QEMU bumping memory limit and domain restore
Date: Thu, 4 Jun 2015 10:32:05 +0100	[thread overview]
Message-ID: <55701B15.9060007@citrix.com> (raw)
In-Reply-To: <1433409984.7108.90.camel@citrix.com>

On 04/06/15 10:26, Ian Campbell wrote:
> On Thu, 2015-06-04 at 10:14 +0100, Wei Liu wrote:
>> The main objection is that we shouldn't call xc_domain_setmaxmem in the
>> middle of a migration stream.
> In the middle of an _xc_ migration stream.
>
> This seems like the sort of thing it would be OK to have in a (to be
> introduced) libxl stream (which would itself contain the xc stream as a
> data item).
>
> I think we are expecting such a thing to be introduced as part of the
> libxl side of migration v2, aren't we?

No.  libxl migration v2 will not be affecting the behaviour here.

The only reasonable way I see this being fixed is for the libxl json
blob to contain the correct size of the VM, and for
libxl_domain_create() to make an appropriately sized VM in the first place.

One extension which libxl migration v2 will bring is the ability to send
a new json blob later in the stream, but such a fix still requires the
json blob to have the correct size in it.

~Andrew

  reply	other threads:[~2015-06-04  9:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-02 14:05 RFC: QEMU bumping memory limit and domain restore Wei Liu
2015-06-02 14:08 ` Wei Liu
2015-06-02 15:49   ` Ian Campbell
2015-06-02 16:11     ` Andrew Cooper
2015-06-02 17:40       ` Wei Liu
2015-06-04 15:28         ` Wei Liu
2015-06-04 15:49           ` Ian Campbell
2015-06-05 13:09           ` Wei Liu
2015-06-02 17:32     ` Wei Liu
2015-06-03  1:05     ` Yang Hongyang
2015-06-03 13:22 ` George Dunlap
2015-06-03 13:32   ` Andrew Cooper
2015-06-03 13:53     ` George Dunlap
2015-06-03 16:11       ` Don Slutz
2015-06-04  9:14   ` Wei Liu
2015-06-04  9:26     ` Ian Campbell
2015-06-04  9:32       ` Andrew Cooper [this message]
2015-06-04  9:46         ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55701B15.9060007@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=andrew@zion.uk.xensource.com \
    --cc=dslutz@verizon.com \
    --cc=ian.campbell@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    --cc=yanghy@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.