From mboxrd@z Thu Jan 1 00:00:00 1970 From: Razvan Cojocaru Subject: Re: [PATCH V8] xen/vm_event: Clean up control-register-write vm_events and add XCR0 event Date: Thu, 04 Jun 2015 16:47:23 +0300 Message-ID: <557056EB.50309@bitdefender.com> References: <1432907159-21899-1-git-send-email-rcojocaru@bitdefender.com> <20150604134015.GD74656@deinos.phlegethon.org> <20150604134332.GE74656@deinos.phlegethon.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150604134332.GE74656@deinos.phlegethon.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tim Deegan Cc: kevin.tian@intel.com, wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, jun.nakajima@intel.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, eddie.dong@intel.com, jbeulich@suse.com, keir@xen.org List-Id: xen-devel@lists.xenproject.org On 06/04/2015 04:43 PM, Tim Deegan wrote: > At 14:40 +0100 on 04 Jun (1433428815), Tim Deegan wrote: >> At 16:45 +0300 on 29 May (1432917959), Razvan Cojocaru wrote: >>> As suggested by Andrew Cooper, this patch attempts to remove >>> some redundancy and allow for an easier time when adding vm_events >>> for new control registers in the future, by having a single >>> VM_EVENT_REASON_WRITE_CTRLREG vm_event type, meant to serve CR0, >>> CR3, CR4 and (newly introduced) XCR0. The actual control register >>> will be deduced by the new .index field in vm_event_write_ctrlreg >>> (renamed from vm_event_mov_to_cr). The patch has also modified >>> the xen-access.c test - it is now able to log CR3 events. >>> >>> Signed-off-by: Razvan Cojocaru >>> Acked-by: Jan Beulich >> >> Acked-by: Tim Deegan > > Ah, I see I've acked an old version. The ack stands for v9, whough if > you're going to v10, can you please rename the macro to, e,g, > > #define hvm_event_crX(what, new, old) \ > hvm_event_cr(VM_EVENT_X86_##what, new, old) Of course, if Jan (who originally proposed the macro) doesn't have any objections, I'll rename it. Thanks, Razvan