From: Jens Axboe <axboe@fb.com>
To: Ming Lei <tom.leiming@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Stefan Seyfried <stefan.seyfried@googlemail.com>,
NeilBrown <neilb@suse.de>, Christoph Hellwig <hch@lst.de>,
"v4.0" <stable@vger.kernel.org>
Subject: Re: [PATCH] blk-mq: free hctx->ctxs in queue's release handler
Date: Thu, 4 Jun 2015 08:10:38 -0600 [thread overview]
Message-ID: <55705C5E.9080401@fb.com> (raw)
In-Reply-To: <CACVXFVP+9w-aAn+ZprrpEy0XKqgiY5i+eQWWxDKiMKBPJGRKEA@mail.gmail.com>
On 06/04/2015 07:19 AM, Ming Lei wrote:
> On Thu, Jun 4, 2015 at 9:14 PM, Ming Lei <tom.leiming@gmail.com> wrote:
>> Now blk_cleanup_queue() can be called before calling
>> del_gendisk()[1], inside which hctx->ctxs is touched
>> from blk_mq_unregister_hctx(), but the variable has
>> been freed by blk_cleanup_queue() at that time.
>>
>> So this patch moves freeing of hctx->ctxs into queue's
>> release handler for fixing the oops reported by Stefan.
>>
>> Also ctx's kobject is embedded into each ctx pointed by
>> hctx->ctxs[], which shouldn't have been released so early.
>
> Hammm, the above line is wrong and should be removed, and
> hctx->ctxs[] just stores the pointer of ctx.
>
> Jens, if you need v1, please let me know.
Yeah, lets respin it please.
--
Jens Axboe
prev parent reply other threads:[~2015-06-04 14:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 13:14 [PATCH] blk-mq: free hctx->ctxs in queue's release handler Ming Lei
2015-06-04 13:19 ` Ming Lei
2015-06-04 14:10 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55705C5E.9080401@fb.com \
--to=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=stable@vger.kernel.org \
--cc=stefan.seyfried@googlemail.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.