diff for duplicates of <55706D41.9090803@bfs.de> diff --git a/a/1.txt b/N1/1.txt index dceaf0d..282be6c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -48,11 +48,11 @@ Am 04.06.2015 16:47, schrieb Dan Carpenter: > /* send a reset to the SCSI LUN which the command was sent to */ > rc = hpsa_do_reset(h, dev, dev->scsi3addr, HPSA_RESET_TYPE_LUN, > DEFAULT_REPLY_QUEUE); -> - sprintf(msg, "reset %s", rc = 0 ? "completed successfully" : "failed"); +> - sprintf(msg, "reset %s", rc == 0 ? "completed successfully" : "failed"); > + snprintf(msg, sizeof(msg), "reset %s", -> + rc = 0 ? "completed successfully" : "failed"); +> + rc == 0 ? "completed successfully" : "failed"); > hpsa_show_dev_msg(KERN_WARNING, h, dev, msg); -> return rc = 0 ? SUCCESS : FAILED; +> return rc == 0 ? SUCCESS : FAILED; > } diff --git a/a/content_digest b/N1/content_digest index c6862ab..d706900 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\020150604144756.GA8897@mwanda\0" "From\0walter harms <wharms@bfs.de>\0" "Subject\0Re: [patch] hpsa: fix an sprintf() overflow in the reset handler\0" - "Date\0Thu, 04 Jun 2015 15:22:41 +0000\0" + "Date\0Thu, 04 Jun 2015 17:22:41 +0200\0" "To\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Cc\0Don Brace <don.brace@pmcs.com>" James E.J. Bottomley <JBottomley@odin.com> @@ -61,11 +61,11 @@ "> \t/* send a reset to the SCSI LUN which the command was sent to */\n" "> \trc = hpsa_do_reset(h, dev, dev->scsi3addr, HPSA_RESET_TYPE_LUN,\n" "> \t\t\t DEFAULT_REPLY_QUEUE);\n" - "> -\tsprintf(msg, \"reset %s\", rc = 0 ? \"completed successfully\" : \"failed\");\n" + "> -\tsprintf(msg, \"reset %s\", rc == 0 ? \"completed successfully\" : \"failed\");\n" "> +\tsnprintf(msg, sizeof(msg), \"reset %s\",\n" - "> +\t\t rc = 0 ? \"completed successfully\" : \"failed\");\n" + "> +\t\t rc == 0 ? \"completed successfully\" : \"failed\");\n" "> \thpsa_show_dev_msg(KERN_WARNING, h, dev, msg);\n" - "> \treturn rc = 0 ? SUCCESS : FAILED;\n" + "> \treturn rc == 0 ? SUCCESS : FAILED;\n" "> }\n" "\n" "\n" @@ -78,4 +78,4 @@ "just my 2 cents,\n" wh -61a4c7032b9b16af0042af908d4905ed3028f909aeb8e914d174a6f13fa7d988 +0318415d49400823c760d06c0e3eebdc944943a2cf99f6976b8cd844de55e656
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.