From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <don.slutz@gmail.com>
Subject: Re: [PATCH v11 3/9] tools: Add vmware_hwver support
Date: Thu, 04 Jun 2015 11:59:39 -0400
Message-ID: <557075EB.401@Gmail.com>
References: <1432309826-6420-1-git-send-email-dslutz@verizon.com>	<1432309826-6420-4-git-send-email-dslutz@verizon.com>
	<1433431028.7108.117.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1433431028.7108.117.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>, Don Slutz <dslutz@verizon.com>
Cc: Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>, Eddie Dong <eddie.dong@intel.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>, xen-devel@lists.xen.org, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
List-Id: xen-devel@lists.xenproject.org

On 06/04/15 11:17, Ian Campbell wrote:
> On Fri, 2015-05-22 at 11:50 -0400, Don Slutz wrote:
>> [...] 
>> +=item B<vmware_hwver=NUMBER>
>> +
>> +Turns on or off the exposure of VMware cpuid.  The number is
>> +VMware's hardware version number, where 0 is off.  A number >= 7
>> +is needed to enable exposure of VMware cpuid.
>> +
>> +The hardware version number (vmware_hwver) come from VMware config files.
> 
> "comes"
> 

Will fix.

>> diff --git a/tools/libxc/xc_domain.c b/tools/libxc/xc_domain.c
>> index 38d065f..4362d5d 100644
>> --- a/tools/libxc/xc_domain.c
>> +++ b/tools/libxc/xc_domain.c
>> @@ -64,7 +64,7 @@ int xc_domain_create(xc_interface *xch,
>>      memset(&config, 0, sizeof(config));
>>  
>>  #if defined (__i386) || defined(__x86_64__)
>> -    /* No arch-specific configuration for now */
>> +    /* No arch-specific default configuration for now */
> 
> I'm not sure this hunk has anything to do with this patch, nor what the
> semantic difference between the old and new text is supposed to be.
> 

I do not have to make this change.  However I feel the comment is
misleading, and I changed it.  The real change is later:


diff --git a/tools/libxl/libxl_x86.c b/tools/libxl/libxl_x86.c
index 651b338..fd7dafa 100644
--- a/tools/libxl/libxl_x86.c
+++ b/tools/libxl/libxl_x86.c
@@ -5,8 +5,7 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
                                       libxl_domain_config *d_config,
                                       xc_domain_configuration_t *xc_config)
 {
-    /* Note: will be changed in a later patch */
-    xc_config->vmware_hwver = 0;
+    xc_config->vmware_hwver = d_config->c_info.vmware_hwver;
     return 0;
 }

which is where "arch-specific configuration" is done.  This is where the
default "arch-specific configuration" is done.

   -Don Slutz


> Ian.
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>