From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <dslutz@verizon.com>
Subject: Re: [PATCH v11 7/9] tools: Add vmware_port support
Date: Thu, 04 Jun 2015 12:09:41 -0400
Message-ID: <55707845.2050900@one.verizon.com>
References: <1432309826-6420-1-git-send-email-dslutz@verizon.com>	
	<1432309826-6420-8-git-send-email-dslutz@verizon.com>	
	<556F33FE.4070700@eu.citrix.com>
	<1433432953.7108.122.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1433432953.7108.122.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>
Cc: Tim Deegan <tim@xen.org>, Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>, Jun Nakajima <jun.nakajima@intel.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Eddie Dong <eddie.dong@intel.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
List-Id: xen-devel@lists.xenproject.org

On 06/04/15 11:49, Ian Campbell wrote:
> On Wed, 2015-06-03 at 18:06 +0100, George Dunlap wrote:
>> On 05/22/2015 04:50 PM, Don Slutz wrote:
>>> This new libxl_domain_create_info field is used to set
>>> XEN_DOMCTL_CONFIG_VMWARE_PORT_MASK in the xc_domain_configuration_t
>>> for x86.
>>>
>>> In xen it is is_vmware_port_enabled.
>>>
>>> If is_vmware_port_enabled then
>>>   enable a limited support of VMware's hyper-call.
>>>
>>> VMware's hyper-call is also known as VMware Backdoor I/O Port.
>>>
>>> if vmware_port is not specified in the config file, let
>>> "vmware_hwver != 0" be the default value.  This means that only
>>> vmware_hwver = 7 needs to be specified to enable both features.
>>>
>>> vmware_hwver = 7 is special because that is what controls the
>>> enable of CPUID leaves for VMware (vmware_hwver >= 7).
>>>
>>> Note: vmware_port and nestedhvm cannot be specified at the
>>> same time.
>>>
>>> Signed-off-by: Don Slutz <dslutz@verizon.com>
>>
>> Ian:
>>
>> So I *think* it may be the case that this patch only depends on patch 5
>> to apply.  I also think that patches 5 and 7 together add another useful
>> "chunk" of functionality (core vmport functionality for guest OSes).
> 
> Is there any point in this chunk without 1..3?
> 
> 

There may be.  However changes would need to be done if 2 and 3 are not
present.

Patch #1 is independent.

Pacth 2,3 provide CPUID support, which is not always needed.

Just 5,7 and 8 may work to provide X windows usage of vmware mouse.  I
have not tested with just this set.  This is because most Xservers run
with IOPL set to 3 and so do not need patch #6.  My memory also says
that CPUID support is not needed (which is what you get for vmware_hwver=3).


   -Don Slutz