All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Smalley <sds@tycho.nsa.gov>
To: Paul Moore <pmoore@redhat.com>, selinux@tycho.nsa.gov
Subject: Re: [PATCH 3/3] selinux-testsuite: fix compile warnings in tests/execshare
Date: Thu, 04 Jun 2015 12:29:40 -0400	[thread overview]
Message-ID: <55707CF4.4050807@tycho.nsa.gov> (raw)
In-Reply-To: <20150604161538.4124.38211.stgit@localhost>

On 06/04/2015 12:15 PM, Paul Moore wrote:
> Correct the following:
> 
> make[2]: Entering directory '/root/sources/selinux-testsuite/tests/execshare'
> cc     parent.c  -lselinux -o parent
> parent.c: In function 'main':
> parent.c:83:8: warning: implicit declaration of function 'clone'
>   pid = clone(clone_fn, clone_stack, cloneflags | SIGCHLD, argv);
>         ^
> 
> Signed-off-by: Paul Moore <paul@paul-moore.com>

Acked-by: Stephen Smalley <sds@tycho.nsa.gov>

Although maybe we should just add -D_GNU_SOURCE to CFLAGS in the
tests/Makefile...

> ---
>  tests/execshare/parent.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/execshare/parent.c b/tests/execshare/parent.c
> index 86f6ae9..343c35f 100644
> --- a/tests/execshare/parent.c
> +++ b/tests/execshare/parent.c
> @@ -1,3 +1,6 @@
> +
> +#define _GNU_SOURCE
> +
>  #include <stdio.h>
>  #include <stdlib.h>
>  #include <unistd.h>
> 

  reply	other threads:[~2015-06-04 16:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-04 16:15 [PATCH 0/3] SELinux testsuite compilation fixes Paul Moore
2015-06-04 16:15 ` [PATCH 1/3] selinux-testsuite: fix some compile warnings in tests/nnp Paul Moore
2015-06-04 16:15 ` [PATCH 2/3] selinux-testsuite: fix compile warnings in tests/setnice Paul Moore
2015-06-04 16:15 ` [PATCH 3/3] selinux-testsuite: fix compile warnings in tests/execshare Paul Moore
2015-06-04 16:29   ` Stephen Smalley [this message]
2015-06-04 19:26     ` Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55707CF4.4050807@tycho.nsa.gov \
    --to=sds@tycho.nsa.gov \
    --cc=pmoore@redhat.com \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.