From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= Subject: Re: drm/amdkfd: bad CONFIG_ prefix for enum entries Date: Thu, 04 Jun 2015 18:47:53 +0200 Message-ID: <55708139.7010900@vodafone.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from pegasos-out.vodafone.de (pegasos-out.vodafone.de [80.84.1.38]) by gabe.freedesktop.org (Postfix) with ESMTP id E10DB6EB8B for ; Thu, 4 Jun 2015 09:48:02 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alex Deucher , Valentin Rothberg Cc: Paul Bolle , hengelein Stefan , Andreas Ruprecht , Maling list - DRI developers , LKML List-Id: dri-devel@lists.freedesktop.org T24gMDQuMDYuMjAxNSAxNzowOSwgQWxleCBEZXVjaGVyIHdyb3RlOgo+IE9uIFRodSwgSnVuIDQs IDIwMTUgYXQgMTA6MDQgQU0sIFZhbGVudGluIFJvdGhiZXJnCj4gPHZhbGVudGlucm90aGJlcmdA Z21haWwuY29tPiB3cm90ZToKPj4gSGkgQWxleCwKPj4KPj4gT24gVGh1LCBKdW4gNCwgMjAxNSBh dCA0OjAxIFBNLCBBbGV4IERldWNoZXIgPGFsZXhkZXVjaGVyQGdtYWlsLmNvbT4gd3JvdGU6Cj4+ PiBPbiBUaHUsIEp1biA0LCAyMDE1IGF0IDk6NDggQU0sIE9kZWQgR2FiYmF5IDxvZGVkLmdhYmJh eUBnbWFpbC5jb20+IHdyb3RlOgo+Pj4+IEhpIFZhbGVudGluLAo+Pj4+IFRoYW5rcyBmb3IgY2F0 Y2hpbmcgdGhhdC4KPj4+PiBJIHdvdWxkIGJlIGdyYXRlZnVsIGlmIHlvdSBjb3VsZCBmaXggdGhp cyB5b3Vyc2VsZi4KPj4+IFBsZWFzZSB0cnkgYW5kIGtlZXAgQ09ORklHIGluIHRoZSBuYW1lIHNp bmNlIHRoaXMgcmFuZ2Ugb2YgcmVnaXN0ZXJzCj4+PiBhcmUgY2FsbGVkIENPTkZJRyByZWdpc3Rl cnMuCj4+IEkgY2Fubm90IGZvcmNlIGNoYW5naW5nIHRob3NlIHN5bWJvbHMsIGJ1dCBwb2ludCBv dXQgdGhhdCBpdCdzCj4+IHZpb2xhdGluZyBuYW1pbmcgY29udmVudGlvbnMuICBJIHdvdWxkIHN1 Z2dlc3QgdG8gcy9DT05GSUdfL0NPTkZfLyB0bwo+PiBtYWtlIGNsZWFyIHRoYXQgaXQncyBjb25m aWcgcmVnaXN0ZXJzLiAgV291bGQgeW91IGJlIGZpbmUgd2l0aCB0aGF0Pwo+IFdoYXQgYWJvdXQg c29tZXRoaW5nIGxpa2UgQU1EX0NPTkZJR19SRUc/CgpGb3IgdGhlIGJhY2tncm91bmQ6IFRoZSBy ZWdpc3RlciBoZWFkZXJzIHdpbGwgYmUgYXV0byBnZW5lcmF0ZWQgaW4gdGhlIApmdXR1cmUgYW5k IGlmIHRoZSBoYXJkd2FyZSBkZXNpZ25lciBuYW1lZCB0aGUgcmVnaXN0ZXIgQ09ORklHXyogdGhl IG5hbWUgCndpbGwgc2hvdyB1cCBpbiBvdXIgaGVhZGVycyBhcyBzdWNoLgoKUHJlZml4aW5nIGl0 IHdpdGggQU1EXyBzb3VuZHMgbGlrZSBhIGdvb2Qgc29sdXRpb24gdG8gbWUsIHRvby4KClJlZ2Fy ZHMsCkNocmlzdGlhbi4KCj4KPj4gS2luZCByZWdhcmRzLAo+PiAgIFZhbGVudGluCj4+Cj4+PiBB bGV4Cj4+Pgo+Pj4+IE9kZWQKPj4+Pgo+Pj4+IE9uIFRodSwgSnVuIDQsIDIwMTUgYXQgNDo0NSBQ TSBWYWxlbnRpbiBSb3RoYmVyZwo+Pj4+IDx2YWxlbnRpbnJvdGhiZXJnQGdtYWlsLmNvbT4gd3Jv dGU6Cj4+Pj4+IEhpIFlhaXIsCj4+Pj4+Cj4+Pj4+IHlvdXIgY29tbWl0IGZiZWI2NjFiZmE4OSAo ImRybS9hbWRrZmQ6IEFkZCBza2VsZXRvbiBIL1cgZGVidWdnZXIKPj4+Pj4gbW9kdWxlIHN1cHBv cnQiKSBoYXMgc2hvd24gdXAgaW4gdG9kYXkncyBsaW51eC1uZXh0IHRyZWUgKGkuZS4sCj4+Pj4+ IG5leHQtMjAxNTA2MDQpLiAgVGhlIGNvbW1pdCBhZGRzIHRoZSBmb2xsb3dpbmcgbGluZXMgb2Yg Y29kZSB0bwo+Pj4+PiBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfZGJnZGV2Lmg6Cj4+ Pj4+Cj4+Pj4+ICsvKiBDT05GSUcgcmVnIHNwYWNlIGRlZmluaXRpb24gKi8KPj4+Pj4gK2VudW0g ewo+Pj4+PiArICAgICAgIENPTkZJR19SRUdfQkFTRSA9IDB4MjAwMCwgICAgICAgLyogaW4gZHdv cmRzICovCj4+Pj4+ICsgICAgICAgQ09ORklHX1JFR19FTkQgPSAweDJCMDAsCj4+Pj4+ICsgICAg ICAgQ09ORklHX1JFR19TSVpFID0gQ09ORklHX1JFR19FTkQgLSBDT05GSUdfUkVHX0JBU0UKPj4+ Pj4gK307Cj4+Pj4+Cj4+Pj4+IFRoZXJlIGlzIGEgcHJvYmxlbSB3aXRoIHRoZSAnQ09ORklHXycg cHJlZml4IG9mIHRob3NlIGVudHJpZXMuICBUaGlzCj4+Pj4+IHByZWZpeCBpcyByZXNlcnZlZCBm b3IgS2NvbmZpZyBvcHRpb25zIGluIE1ha2UvS2J1aWxkIGFuZCBDUFAgc3ludGF4LAo+Pj4+PiBz byB0aGF0IHN0YXRpYyBhbmFseXNpcyB0b29scyAoYW5kIHJlYWRlcnMgb2YgdGhlIGNvZGUpIG1h eSBtaXN0YWtlbmx5Cj4+Pj4+IGFzc3VtZSB0aGF0IHRoZSBzeW1ib2wgaXMgZGVmaW5lZCBzb21l d2hlcmUgaW4gYSBLY29uZmlnIGZpbGUuCj4+Pj4+Cj4+Pj4+IEkgZGV0ZWN0ZWQgdGhlIGlzc3Vl IHdpdGggLi9zY3JpcHRzL2NoZWNra2NvbmZpZ3N5bWJvbHMucHkuICBXb3VsZCB5b3UKPj4+Pj4g bWluZCByZW5hbWluZyB0aG9zZSBlbnRyaWVzIHRvIHNvbWV0aGluZyB3aXRob3V0IHRoZSAnQ09O RklHXycgcHJlZml4Pwo+Pj4+PiAgIEkgY2FuIGFsc28gdGFrZSBjYXJlIG9mIGl0IGlmIHlvdSB3 aXNoIHRvLgo+Pj4+Pgo+Pj4+PiBLaW5kIHJlZ2FyZHMsCj4+Pj4+ICAgVmFsZW50aW4KPj4+Pgo+ Pj4+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+Pj4g ZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+Pj4+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKPj4+PiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCj4+Pj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754249AbbFDQ4E (ORCPT ); Thu, 4 Jun 2015 12:56:04 -0400 Received: from pegasos-out.vodafone.de ([80.84.1.38]:50673 "EHLO pegasos-out.vodafone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754036AbbFDQz6 (ORCPT ); Thu, 4 Jun 2015 12:55:58 -0400 X-Greylist: delayed 473 seconds by postgrey-1.27 at vger.kernel.org; Thu, 04 Jun 2015 12:55:57 EDT X-Spam-Flag: NO X-Spam-Score: 0.201 Authentication-Results: rohrpostix2.prod.vfnet.de (amavisd-new); dkim=pass header.i=@vodafone.de X-DKIM: OpenDKIM Filter v2.6.8 pegasos-out.vodafone.de 0AD107512E6 Message-ID: <55708139.7010900@vodafone.de> Date: Thu, 04 Jun 2015 18:47:53 +0200 From: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Alex Deucher , Valentin Rothberg CC: Paul Bolle , Andreas Ruprecht , Maling list - DRI developers , LKML , hengelein Stefan Subject: Re: drm/amdkfd: bad CONFIG_ prefix for enum entries References: In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04.06.2015 17:09, Alex Deucher wrote: > On Thu, Jun 4, 2015 at 10:04 AM, Valentin Rothberg > wrote: >> Hi Alex, >> >> On Thu, Jun 4, 2015 at 4:01 PM, Alex Deucher wrote: >>> On Thu, Jun 4, 2015 at 9:48 AM, Oded Gabbay wrote: >>>> Hi Valentin, >>>> Thanks for catching that. >>>> I would be grateful if you could fix this yourself. >>> Please try and keep CONFIG in the name since this range of registers >>> are called CONFIG registers. >> I cannot force changing those symbols, but point out that it's >> violating naming conventions. I would suggest to s/CONFIG_/CONF_/ to >> make clear that it's config registers. Would you be fine with that? > What about something like AMD_CONFIG_REG? For the background: The register headers will be auto generated in the future and if the hardware designer named the register CONFIG_* the name will show up in our headers as such. Prefixing it with AMD_ sounds like a good solution to me, too. Regards, Christian. > >> Kind regards, >> Valentin >> >>> Alex >>> >>>> Oded >>>> >>>> On Thu, Jun 4, 2015 at 4:45 PM Valentin Rothberg >>>> wrote: >>>>> Hi Yair, >>>>> >>>>> your commit fbeb661bfa89 ("drm/amdkfd: Add skeleton H/W debugger >>>>> module support") has shown up in today's linux-next tree (i.e., >>>>> next-20150604). The commit adds the following lines of code to >>>>> drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.h: >>>>> >>>>> +/* CONFIG reg space definition */ >>>>> +enum { >>>>> + CONFIG_REG_BASE = 0x2000, /* in dwords */ >>>>> + CONFIG_REG_END = 0x2B00, >>>>> + CONFIG_REG_SIZE = CONFIG_REG_END - CONFIG_REG_BASE >>>>> +}; >>>>> >>>>> There is a problem with the 'CONFIG_' prefix of those entries. This >>>>> prefix is reserved for Kconfig options in Make/Kbuild and CPP syntax, >>>>> so that static analysis tools (and readers of the code) may mistakenly >>>>> assume that the symbol is defined somewhere in a Kconfig file. >>>>> >>>>> I detected the issue with ./scripts/checkkconfigsymbols.py. Would you >>>>> mind renaming those entries to something without the 'CONFIG_' prefix? >>>>> I can also take care of it if you wish to. >>>>> >>>>> Kind regards, >>>>> Valentin >>>> >>>> _______________________________________________ >>>> dri-devel mailing list >>>> dri-devel@lists.freedesktop.org >>>> http://lists.freedesktop.org/mailman/listinfo/dri-devel >>>> > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel