From: axboe@fb.com (Jens Axboe)
Subject: [PATCH] NVMe: Add reset controller sysfs entry
Date: Thu, 4 Jun 2015 14:12:57 -0600 [thread overview]
Message-ID: <5570B149.3050901@fb.com> (raw)
In-Reply-To: <5570AE5E.6030407@fb.com>
On 06/04/2015 02:00 PM, Jens Axboe wrote:
> On 06/04/2015 09:39 AM, Christoph Hellwig wrote:
>> On Thu, Jun 04, 2015@03:26:03PM +0000, Keith Busch wrote:
>>> On Thu, 4 Jun 2015, Brandon Schulz wrote:
>>>> Do you plan to merge this into your legacy tree somewhere that we can
>>>> reference in Bugzillas/etc. with the Linux distro vendors?
>>>
>>> There is a strong preference with vendors to see fixes upstream prior
>>> to backporting but this is a long-standing percieved weakness in Linux
>>> vs. other operating systems; no one wants to reboot their machine for
>>> a f/w upgrade ... so, okay, I'll apply it to legacy and see if I can
>>> lobby OSVs to take out-of-stream fixes.
>>
>> Eww. Jens, can you please just apply this patch so that we're not
>> having such a mess?
>
> Yeah, I'll apply it now for 4.2.
Well, that was a bit of a mess. Attached is my quick attempt at
combining the two, and reusing the reset code from the ioctl path as
well. One functional change was NOT flushing the work if we don't queue
it in nvme_reset(), the previous code from Keith did that. Otherwise it
should be straight forward.
Please review, I'll hold off on committing this.
--
Jens Axboe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nvme-reset.patch
Type: text/x-patch
Size: 3651 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-nvme/attachments/20150604/ff0c718e/attachment.bin>
next prev parent reply other threads:[~2015-06-04 20:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <D195D453.84EA%brandon.schulz@hgst.com>
2015-06-04 15:26 ` [PATCH] NVMe: Add reset controller sysfs entry Keith Busch
2015-06-04 15:39 ` Christoph Hellwig
2015-06-04 20:00 ` Jens Axboe
2015-06-04 20:12 ` Jens Axboe [this message]
2015-06-04 22:08 ` Keith Busch
2015-06-05 15:42 ` Jens Axboe
2015-06-05 16:22 ` Keith Busch
2015-04-03 21:20 Keith Busch
2015-04-06 16:56 ` Brandon Schulz
2015-05-03 18:26 ` David Sariel
2015-05-12 15:10 ` Keith Busch
2015-05-18 16:57 ` David Sariel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5570B149.3050901@fb.com \
--to=axboe@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.