From mboxrd@z Thu Jan 1 00:00:00 1970 From: Razvan Cojocaru Subject: Re: [PATCH V8] xen/vm_event: Clean up control-register-write vm_events and add XCR0 event Date: Thu, 04 Jun 2015 23:53:31 +0300 Message-ID: <5570BACB.8070705@bitdefender.com> References: <1432907159-21899-1-git-send-email-rcojocaru@bitdefender.com> <20150604134015.GD74656@deinos.phlegethon.org> <20150604134332.GE74656@deinos.phlegethon.org> <557056EB.50309@bitdefender.com> <5570BB9B02000078000D0ED8@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5570BB9B02000078000D0ED8@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , tim@xen.org Cc: kevin.tian@intel.com, wei.liu2@citrix.com, eddie.dong@intel.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, jun.nakajima@intel.com, keir@xen.org, ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org On 06/04/2015 10:56 PM, Jan Beulich wrote: >>>> Razvan Cojocaru 06/04/15 3:46 PM >>> >> On 06/04/2015 04:43 PM, Tim Deegan wrote: >>> At 14:40 +0100 on 04 Jun (1433428815), Tim Deegan wrote: >>>> At 16:45 +0300 on 29 May (1432917959), Razvan Cojocaru wrote: >>>>> As suggested by Andrew Cooper, this patch attempts to remove >>>>> some redundancy and allow for an easier time when adding vm_events >>>>> for new control registers in the future, by having a single >>>>> VM_EVENT_REASON_WRITE_CTRLREG vm_event type, meant to serve CR0, >>>>> CR3, CR4 and (newly introduced) XCR0. The actual control register >>>>> will be deduced by the new .index field in vm_event_write_ctrlreg >>>>> (renamed from vm_event_mov_to_cr). The patch has also modified >>>>> the xen-access.c test - it is now able to log CR3 events. >>>>> >>>>> Signed-off-by: Razvan Cojocaru >>>>> Acked-by: Jan Beulich >>>> >>>> Acked-by: Tim Deegan >>> >>> Ah, I see I've acked an old version. The ack stands for v9, whough if >>> you're going to v10, can you please rename the macro to, e,g, >>> >>> #define hvm_event_crX(what, new, old) \ >>> hvm_event_cr(VM_EVENT_X86_##what, new, old) >> >> Of course, if Jan (who originally proposed the macro) doesn't have any >> objections, I'll rename it. > > While I personally think it's better the way it is now, I don't object to it > being renamed, even less so considering that Tim is the maintainer > of that code and hence should have the final say. Understood, in that case I'll submit V10 tomorrow with the macro renamed to hvm_event_crX() as Tim has suggested. I am assuming that, since this will be the only change, it's fine to keep all the acks. Thanks, Razvan